Skip to content

Fix broken offline mode #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondjacobson merged 2 commits into from
Aug 29, 2024
Merged

Fix broken offline mode #9571

raymondjacobson merged 2 commits into from
Aug 29, 2024

Conversation

@raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Aug 29, 2024

Description

Broken here
https://github.com/AudiusProject/audius-protocol/pull/9494/files#diff-ba19b3b9d4779b557bc0ba41e5c297973e243231065d7214037faa875ac568f7R21

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Offline downloads work

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: 589710c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schottra
Copy link
Contributor

schottra commented Aug 29, 2024

Oof, auto-imports strike again. Thanks for fixing this. 🙏

@raymondjacobson raymondjacobson merged commit 7eb83d7 into main Aug 29, 2024
@raymondjacobson raymondjacobson deleted the rj-fix-broken-offline-mode branch August 29, 2024 17:23
audius-infra pushed a commit that referenced this pull request Aug 31, 2024
Audius Client (Web and Mobile) v1.5.97
b24b804 
[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell
[ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell
[fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler
[ed697c2] New audius-query hook for paginated queries (#9592) JD Francis
[847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell
[760bfee] Center long track/collection titles on mobile (#9598) Reed
[c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers
[74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott
[f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson
[86343d1] Fix search filters (#9595) Sebastian Klingler
[398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson
[0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo
[27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson
[7649131] Remove quality toggle for mobile downloads (#9587) Reed
[92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn
[ef67166] [QA-1536] Remove download all buttons (#9581) Reed
[83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers
[331111e] Update dapp-store build artifacts audius-infra
[d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson
[7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson
[906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott
[c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers
[0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson
[c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed
[7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson
[2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson
[78a028e] Update comment-section-api (#9551) Dylan Jeffers
[fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson
[51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis
[fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott
[39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn
[39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis
[cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson
[c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler
[713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott
[f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson
[ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
[303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers
[97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers
[c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schottra schottra Awaiting requested review from schottra

1 more reviewer

@dharit-tan dharit-tan dharit-tan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @schottra @dharit-tan