[PAY-2918] Migrate track endpoints to SDK - Round 3 #9522

schottra · 2024-08-22T18:47:44Z

Description

Migrates the following endpoints:

getUserTracksByHandle
getUserAiTracksByHandle
getPremiumTracks
getNftGatedTrackSignatures
getRemixes
getRemixing
getStems

The NFT endpoint was a little more involved as we didn't have any documentation for it yet and it uses slightly unconventional request/response format.

How Has This Been Tested?

Used compareSDKResponse to verify migrated values are functionally the same as their legacy counterparts.
NOTE: I was not able to verify the ERC1155 behavior for the NFT endpoint due to not having access to any accounts that have one in a connected wallet. Will keep trying to get this figured out and setup so we can test on staging/RC.

changeset-bot · 2024-08-22T18:47:47Z

⚠️ No Changeset found

Latest commit: fb71905

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra · 2024-08-22T18:51:01Z

packages/common/src/store/account/sagas.ts

+      {
+        handle,
+        userId: Id.parse(currentUserId),
+        limit: 1


This is new. Noticed that we aren't actually using the response here, just checking if the list is > 0. So we don't need to fetch more than one track.

Great change!

schottra · 2024-08-22T18:51:58Z

packages/discovery-provider/src/api/v1/tracks.py

    @record_metrics
    @full_ns.doc(
-        id="""Get Gated Track Signatures""",
+        id="""Get NFT Gated Track Signatures""",


Technically, this changes the name of the SDK method. But since it was previously broken (return type of void), I don't think that's a big deal.

Yup, I highly doubt anyone was using this

schottra · 2024-08-22T18:52:44Z

packages/libs/src/sdk/api/generated/full/apis/TracksApi.ts

    /**
     * @hidden
-     * Gets gated track signatures for passed in gated track ids
+     * Gets the tracks found on the \"Most Loved\" smart playlist


Sorry about the cursed diff. The rename moved the method down one spot in the list and git is confused.

audius-infra · 2024-08-22T19:09:34Z

Preview this change https://demo.audius.co/pay-2918-migrate-track-endpoints-3

…k-endpoints-3 * origin/main: [QA-1499] Fix long usernames overflowing manager mode button (#9519) Run dashboard ci on common changes (#9521) Add react-router dependency (#9520) Move trpc to common (#9518) Active styles for web chat blasts (#9517) Add row and column props to flex (#9505) Handle dupe comment transactions (#9511) route core console through nginx (#9514) [C-4902] Add harmony checkbox (#9510) Audius Protocol v0.6.174 [PAY-3361] ChatBlastSelectAudienceScreen (#9502) [PAY-3228] Implement composer unfurl in mobile (#9504) [QA-1210] Fix popup scrolling issues (#9508) Update logic for allowing chat blast sending (#9509) [PAY-3362] Move link resolver to common hook (#9503) [PAY-3342] Chat upgrade handles prior blasts from both parties. (#9493) Add feature flag refresh (#9506) Audius Protocol v0.6.173

audius-infra · 2024-08-22T20:18:05Z

Preview this change https://demo.audius.co/pay-2918-migrate-track-endpoints-3

schottra · 2024-08-22T20:58:53Z

packages/common/src/adapters/track.ts

  return newTrack
 }
+
+export const stemTrackMetadataFromSDK = (


cc @raymondjacobson I know you have a PR to add the public stems endpoint. I had to write this adapter for our existing usage of the full version. I'm not entirely sure why we need to represent a stem as a full track with mostly null fields (upload validation?). But you'll probably want this to process the response.

audius-infra · 2024-08-22T21:10:15Z

Preview this change https://demo.audius.co/pay-2918-migrate-track-endpoints-3

sliptype

Awesome progress 👏

sliptype · 2024-08-22T21:06:54Z

packages/common/src/store/account/sagas.ts

+      {
+        handle,
+        userId: Id.parse(currentUserId),
+        limit: 1


Great change!

sliptype · 2024-08-22T21:08:44Z

packages/common/src/store/gated-content/sagas.ts

+   * The entry in each token_id array is a hyphen-delimited list of tokenIds.
+   * Example:
+   *   trackMap: { 1: [1, 2], 2: [], 3: [1]}
+   *   query params: '?track_ids=1&token_ids=1-2&track_ids=2&token_ids=&track_ids=3&token_ids=1'


What an insane query param structure

sliptype · 2024-08-22T21:09:25Z

packages/discovery-provider/src/api/v1/tracks.py

    @record_metrics
    @full_ns.doc(
-        id="""Get Gated Track Signatures""",
+        id="""Get NFT Gated Track Signatures""",


Yup, I highly doubt anyone was using this

audius-infra · 2024-08-23T14:44:49Z

Preview this change https://demo.audius.co/pay-2918-migrate-track-endpoints-3

[46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [231571c] Fix relay container (#9528) Raymond Jacobson [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [9f07c22] Handle dupe comment transactions (#9511) Isaac Solo [1813960] route core console through nginx (#9514) alecsavvy

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

schottra added 5 commits August 22, 2024 10:30

migrate getUserTracksByHandle to sdk

3d89838

migrate getUserAiTracksByHandle to sdk

91205dc

migrate getPremiumTracks to sdk

e9c1c73

Add sdk docs for nft gated signatures endpoint

8800512

migrate getNftGatedTrackSignatures endpoint to sdk

82a7417

schottra requested a review from sliptype August 22, 2024 18:47

schottra assigned rickyrombo Aug 22, 2024

pull-request-size bot added the size/XL label Aug 22, 2024

document type adapter

18c9403

schottra commented Aug 22, 2024

View reviewed changes

schottra added 3 commits August 22, 2024 16:56

migrate getRemixes to sdk

be1224c

migrate getRemixing to sdk

018f57c

migrate getStems to SDK

b843d45

pull-request-size bot added size/XXL and removed size/XL labels Aug 22, 2024

schottra commented Aug 22, 2024

View reviewed changes

sliptype approved these changes Aug 22, 2024

View reviewed changes

fix lint error

fb71905

schottra enabled auto-merge (squash) August 23, 2024 14:30

schottra merged commit 46305bb into main Aug 23, 2024

schottra deleted the pay-2918-migrate-track-endpoints-3 branch August 23, 2024 14:53

[PAY-2918] Migrate track endpoints to SDK - Round 3 #9522

[PAY-2918] Migrate track endpoints to SDK - Round 3 #9522

Uh oh!

Conversation

schottra commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 22, 2024

Uh oh!

audius-infra commented Aug 22, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 22, 2024

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

schottra commented Aug 22, 2024 •

edited

Loading

changeset-bot bot commented Aug 22, 2024 •

edited

Loading