Mobile comment fixes #9507

sliptype · 2024-08-21T16:19:14Z

Description

Split up CommentDrawer into multiple files
Fix comment form submission
Replace TouchableOpacity usages with PlainButton
Fix optimistic react count in context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

changeset-bot · 2024-08-21T16:19:18Z

⚠️ No Changeset found

Latest commit: 518f396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-08-21T16:27:04Z

Preview this change https://demo.audius.co/sk-c-4947-comment-actions

Kyle-Shanks · 2024-08-22T15:23:10Z

packages/mobile/src/components/comments/CommentBlock.tsx

+                <Flex direction='row' gap='xs'>
+                  <IconPencil color='subdued' size='xs' />
+                  <Text color='subdued' size='xs'>
+                    Pinned by artist


nit: Should add this and top supporters and stuff to messages object

Kyle-Shanks · 2024-08-22T15:25:09Z

packages/mobile/src/components/comments/CommentDrawerForm.tsx

+      style={{
+        ...styles.form
+      }}


you should be able to pass the bg color directly to Box via the bg or background prop. if not can use Paper for this

Yup backgroundColor works 🙏

Kyle-Shanks · 2024-08-22T15:25:21Z

packages/mobile/src/components/comments/CommentDrawerForm.tsx

+        ...styles.form
+      }}
+    >
+      <Box p='l'>


why Box in a Box?

what's in the box?!!!

just a mistake, consolidated now :)

Kyle-Shanks · 2024-08-22T15:27:11Z

packages/mobile/src/components/comments/CommentDrawerHeader.tsx

+          size='m'
+        />
+      </Flex>
+      <Divider orientation='horizontal' />


this seems like a strange place for the divider to exist. imo should be rendered in the place with the siblings to this element

It kind of felt like the bottom border of the header, but I agree. Moved it between CommentDrawerHeader and CommentDrawerContent

Kyle-Shanks · 2024-08-22T15:28:34Z

packages/mobile/src/components/comments/CommentDrawerHeader.tsx

+        alignItems='center'
+      >
+        <Text variant='body' size='m'>
+          Comments


Kyle-Shanks

nice 👍

DejayJD · 2024-08-22T16:33:35Z

packages/mobile/src/components/comments/CommentDrawerHeader.tsx

+        <Text variant='body' size='m'>
+          Comments
+          {!isLoading && comments?.length ? (
+            <Text color='subdued'>&nbsp;({comments.length})</Text>


nit: the nbsp feels unnecessary here?

I needed the space between Comments and the comment count. I could use styles but the nbsp acts as an actual space

makes sense, disregard

DejayJD · 2024-08-22T16:41:06Z

packages/mobile/src/components/comments/CommentForm.tsx

+          style={{ width: 40, height: 40, flexShrink: 0 }}
+        />
+      ) : null}
+      <Box flex={1}>


nit: should be able to just put this directly onto the TextField via css prop instead of needing a wrapper

<HarmonyTextField css={{flex: 1}} />

nice, that's better 🙏

DejayJD · 2024-08-22T16:42:44Z

packages/mobile/src/components/comments/CommentForm.tsx

+      <Box flex={1}>
+        <HarmonyTextField
+          name='commentMessage'
+          label='Add a comment'


nit: prefer messages (probably I need to update this on web too lol)

DejayJD · 2024-08-22T17:14:09Z

packages/mobile/src/components/comments/CommentThread.tsx

-              </Text>
-            </Flex>
-          </TouchableOpacity>
+          <Box mv='xs'>


nit: should be able to also use css prop on the PlainButton here as well

DejayJD

Looking good!

audius-infra · 2024-08-22T19:47:07Z

Preview this change https://demo.audius.co/sk-c-4947-comment-actions

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

sliptype added 4 commits August 20, 2024 14:40

Comment post and react

db60113

Add drawer close button

4214f86

Small refactor

92d6efb

Replace TouchableOpacities with plain buttons

78db989

sliptype requested review from DejayJD, Kyle-Shanks and dylanjeffers August 21, 2024 16:19

pull-request-size bot added the size/L label Aug 21, 2024

Kyle-Shanks reviewed Aug 22, 2024

View reviewed changes

Kyle-Shanks approved these changes Aug 22, 2024

View reviewed changes

DejayJD reviewed Aug 22, 2024

View reviewed changes

DejayJD approved these changes Aug 22, 2024

View reviewed changes

sliptype added 2 commits August 22, 2024 14:35

Address pr comments

3350596

Lint fix

518f396

sliptype merged commit 93e3ac9 into main Aug 22, 2024

sliptype deleted the sk-c-4947-comment-actions branch August 22, 2024 20:03

Mobile comment fixes #9507

Mobile comment fixes #9507

Uh oh!

Conversation

sliptype commented Aug 21, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Aug 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks left a comment

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DejayJD left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Aug 21, 2024 •

edited

Loading

DejayJD Aug 22, 2024 •

edited

Loading

DejayJD Aug 22, 2024 •

edited

Loading