[PAY-3360] Chat Blast CTA (mobile) #9491

amendelsohn · 2024-08-20T01:33:03Z

Description

Added Chat Blast CTA which floats at the bottom of ChatUserListScreen
- Pressing it doesn't do anything yet, but will hook it up once the drawer is implemented
Fixed export of common create-chat-blast-modal

Note: this layout is per the designs, but we'll need to adjust so the width fits on phone screens

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

changeset-bot · 2024-08-20T01:33:07Z

⚠️ No Changeset found

Latest commit: ebbb4d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gitguardian · 2024-08-20T01:33:08Z

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9412812	Triggered	Generic Password	`fb1c9e4`	core/infra/docker-compose.yml	View secret
11648676	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/sandbox-one.env	View secret
11648676	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/discovery-one.docker.env	View secret
11648676	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/discovery-one.env	View secret
11648678	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-three.docker.env	View secret
11648678	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-three.env	View secret
11648679	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-two.env	View secret
11648679	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-two.docker.env	View secret
11648680	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-one.env	View secret
11648680	Triggered	Generic High Entropy Secret	`fb1c9e4`	core/infra/dev_config/content-one.docker.env	View secret
13407071	Triggered	Generic High Entropy Secret	`fb1c9e4`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-20T01:53:38Z

Preview this change https://demo.audius.co/am-PAY-3205

dharit-tan · 2024-08-20T16:46:10Z

packages/mobile/src/screens/chat-screen/ChatBlastCTA.tsx

@@ -0,0 +1,118 @@
+import React, { useCallback } from 'react'


i think we no longer need to import React?

dharit-tan · 2024-08-20T16:47:00Z

packages/mobile/src/screens/chat-screen/ChatBlastCTA.tsx

+  const { onOpen: openChatBlastModal } = useChatBlastModal()
+
+  const { data: userId } = useGetCurrentUserId({})
+  const { tierNumber, isVerified } = useSelectTierInfo(userId ?? 0) ?? {}


wondering if it makes sense to make this hook accept optionaly userId and just return early if it's undefined. easier than always having to ?? 0. but doesn't need to be this PR.

dharit-tan · 2024-08-20T16:47:15Z

packages/mobile/src/screens/chat-screen/ChatBlastCTA.tsx

+
+  const { data: userId } = useGetCurrentUserId({})
+  const { tierNumber, isVerified } = useSelectTierInfo(userId ?? 0) ?? {}
+  const userMeetsRequirements = isVerified || (tierNumber && tierNumber > 0)


maybe we should make this part shared between web/mobile

dharit-tan

nice!

amendelsohn · 2024-08-20T16:54:31Z

packages/mobile/src/screens/chat-screen/ChatBlastCTA.tsx

+  )
+}
+
+const ChatBlastDisabled = () => {


updated from design, this should just be removed. We can return null instead.

audius-infra · 2024-08-20T18:27:07Z

Preview this change https://demo.audius.co/am-PAY-3205

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

amendelsohn added 7 commits August 14, 2024 10:29

wip

8ece955

wip

6a56d34

Merge branch 'main' into am-PAY-3205

fb1c9e4

bottom float working

4b880c6

fix modal export

ae388e8

cleanup

fdb43e5

cleanup

af0e244

amendelsohn requested review from dharit-tan and rickyrombo August 20, 2024 01:33

amendelsohn assigned stereosteve Aug 20, 2024

pull-request-size bot added the size/L label Aug 20, 2024

Merge branch 'main' into am-PAY-3205

830a2b5

dharit-tan reviewed Aug 20, 2024

View reviewed changes

dharit-tan approved these changes Aug 20, 2024

View reviewed changes

amendelsohn commented Aug 20, 2024

View reviewed changes

amendelsohn added 2 commits August 20, 2024 10:34

remove disabled state

fc08a87

revert hook change

ebbb4d3

amendelsohn merged commit d55dbb1 into main Aug 20, 2024

amendelsohn deleted the am-PAY-3205 branch August 20, 2024 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-3360] Chat Blast CTA (mobile) #9491

[PAY-3360] Chat Blast CTA (mobile) #9491

Uh oh!

amendelsohn commented Aug 20, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 20, 2024 •

edited

Loading

Uh oh!

gitguardian bot commented Aug 20, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

dharit-tan Aug 20, 2024

Uh oh!

dharit-tan Aug 20, 2024

Uh oh!

dharit-tan Aug 20, 2024

Uh oh!

dharit-tan left a comment

Uh oh!

amendelsohn Aug 20, 2024

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[PAY-3360] Chat Blast CTA (mobile) #9491

[PAY-3360] Chat Blast CTA (mobile) #9491

Uh oh!

Conversation

amendelsohn commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

gitguardian bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

dharit-tan Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

amendelsohn Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amendelsohn commented Aug 20, 2024 •

edited

Loading

changeset-bot bot commented Aug 20, 2024 •

edited

Loading

gitguardian bot commented Aug 20, 2024 •

edited

Loading