[PAY-3355] Address link preview / unfurl QA items #9492

raymondjacobson · 2024-08-20T08:06:40Z

Description

This PR should be reviewed commit by commit In that case it's not all that scary!

Move many route utils to common to fix env usage

This change moves a lot of web/utils/route to common/utils/route in order to fix a longstanding bug we have where staging links are often shared as prod links. This was because the web route file was used in mobile and can't handle env var injection as it is since most exports are static.

Fix share to DM composer link resolution

This change fixes an issue where "share to DM" doesn't unfurl because the preview changing doesn't fire an event handler change

Resolve premium tracks in bulk tracks non-full API

Discovery node change to fix the fact that resolve is broken for premium content because it uses the non-full route. No reason non-full can't return premium, so update that.

Handle collections and users

Supports users & collections

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

npm run web:stage

tested tracks, users, collections, etc.

changeset-bot · 2024-08-20T08:06:44Z

🦋 Changeset detected

Latest commit: fba07a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@audius/sdk	Patch
@audius/sp-actions	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

audius-infra · 2024-08-20T08:26:10Z

Preview this change https://demo.audius.co/rj-pay-3355

rickyrombo

🔥

audius-infra · 2024-08-20T17:06:35Z

Preview this change https://demo.audius.co/rj-pay-3355

audius-infra · 2024-08-20T18:03:05Z

Preview this change https://demo.audius.co/rj-pay-3355

packages/discovery-provider/src/api/v1/tracks.py

packages/libs/src/sdk/api/ResolveApi.ts

dharit-tan · 2024-08-20T21:18:31Z

packages/web/src/pages/chat-page/components/ChatComposer.tsx

  // The track id used to render the composer preview
  const [trackId, setTrackId] = useState<ID | null>(null)
+  // The collection id used to render the composer preview
+  const [collectionId, setCollectionId] = useState<ID | null>(null)


nit: could use Nullable

will address in follow up PR! good good

dharit-tan

the typeguard thing is annoying, would like to see a better pattern for that, but if u wanna just check this in for now i'm ok with it.

audius-infra · 2024-08-20T21:40:54Z

Preview this change https://demo.audius.co/rj-pay-3355

raymondjacobson · 2024-08-20T22:38:39Z

the typeguard thing is annoying, would like to see a better pattern for that, but if u wanna just check this in for now i'm ok with it.

did a little better here using some SDK things. next PR will clean up this code even more

audius-infra · 2024-08-20T22:53:18Z

Preview this change https://demo.audius.co/rj-pay-3355

[78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [a0e8fae] Remove rule 13 from blocking relay (#9496) Isaac Solo [49d2716] [QA-1517] Include UserID in websocket metadata (#9497) Reed [d19c208] [PAY-3309] Add is_hidden column to chat_member (#9483) Steve Perkins

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

raymondjacobson added 5 commits August 19, 2024 23:48

Move many route utils to common to fix env usage

3ce84d8

Fix share to DM composer link resolution

a75da6d

Resolve premium tracks in bulk tracks non-full API

d4b50b8

Handle collections and users

ac8a7ec

Add changeset

2491e6a

pull-request-size bot added the size/XXL label Aug 20, 2024

raymondjacobson requested a review from dharit-tan August 20, 2024 08:07

rickyrombo approved these changes Aug 20, 2024

View reviewed changes

Fix tests

3e204d5

dharit-tan reviewed Aug 20, 2024

View reviewed changes

packages/discovery-provider/src/api/v1/tracks.py Show resolved Hide resolved

dharit-tan reviewed Aug 20, 2024

View reviewed changes

packages/libs/src/sdk/api/ResolveApi.ts Outdated Show resolved Hide resolved

dharit-tan reviewed Aug 20, 2024

View reviewed changes

dharit-tan approved these changes Aug 20, 2024

View reviewed changes

Update bundlesize configs

7207950

raymondjacobson added 3 commits August 20, 2024 15:33

Merge main

6da3d86

Clean up

2fbc4b1

Merge remote-tracking branch 'origin/main' into rj-pay-3355

fba07a6

raymondjacobson merged commit 78897c4 into main Aug 20, 2024

raymondjacobson deleted the rj-pay-3355 branch August 20, 2024 23:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-3355] Address link preview / unfurl QA items #9492

[PAY-3355] Address link preview / unfurl QA items #9492

Uh oh!

raymondjacobson commented Aug 20, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 20, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

rickyrombo left a comment

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Uh oh!

Uh oh!

dharit-tan Aug 20, 2024

Uh oh!

raymondjacobson Aug 20, 2024

Uh oh!

dharit-tan left a comment

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

raymondjacobson commented Aug 20, 2024

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[PAY-3355] Address link preview / unfurl QA items #9492

[PAY-3355] Address link preview / unfurl QA items #9492

Uh oh!

Conversation

raymondjacobson commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

rickyrombo left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Uh oh!

Uh oh!

dharit-tan Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

raymondjacobson Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

raymondjacobson commented Aug 20, 2024

Uh oh!

audius-infra commented Aug 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raymondjacobson commented Aug 20, 2024 •

edited

Loading

changeset-bot bot commented Aug 20, 2024 •

edited

Loading