-
Notifications
You must be signed in to change notification settings - Fork 126
[PAY-3309] Add is_hidden column to chat_member #9483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
||
| // set chat_member.is_hidden to false | ||
| // if there are any non-blast messages | ||
| // or any blasts from the other party |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gonna need to include reactions too eventually
dharit-tan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
| b.from_user_id != member.user_id | ||
| ) | ||
| ) | ||
| WHERE member.chat_id = $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would adding a WHERE clause for is_hidden=true make this do less work for the happy path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out... but then tests fails because member row initially gets inserted with is_hidden = false and then this sets it to true when applicable.
Anyway there is an index on member.chat_id which is quite selective... savings would be small
Hides a thread unless there are valid chat messages or blasts from the other party.