Skip to content

Conversation

@stereosteve
Copy link
Contributor

Hides a thread unless there are valid chat messages or blasts from the other party.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2024

⚠️ No Changeset found

Latest commit: cdf118d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


// set chat_member.is_hidden to false
// if there are any non-blast messages
// or any blasts from the other party
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna need to include reactions too eventually

Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

b.from_user_id != member.user_id
)
)
WHERE member.chat_id = $1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would adding a WHERE clause for is_hidden=true make this do less work for the happy path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out... but then tests fails because member row initially gets inserted with is_hidden = false and then this sets it to true when applicable.

Anyway there is an index on member.chat_id which is quite selective... savings would be small

@stereosteve stereosteve merged commit d19c208 into main Aug 20, 2024
@stereosteve stereosteve deleted the sp-chat-member-is-hidden branch August 20, 2024 15:24
audius-infra pushed a commit that referenced this pull request Aug 21, 2024
[78897c4] [PAY-3355] Address link preview / unfurl QA items  (#9492) Raymond Jacobson
[a0e8fae] Remove rule 13 from blocking relay (#9496) Isaac Solo
[49d2716] [QA-1517] Include UserID in websocket metadata (#9497) Reed
[d19c208] [PAY-3309] Add is_hidden column to chat_member (#9483) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants