Skip to content

[QA-1517] Include UserID in websocket metadata #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dharit-tan merged 1 commit into from
Aug 20, 2024
Merged

[QA-1517] Include UserID in websocket metadata #9497

dharit-tan merged 1 commit into from
Aug 20, 2024

Conversation

@dharit-tan
Copy link
Contributor

@dharit-tan dharit-tan commented Aug 20, 2024 •
edited
Loading

Description

This was causing a bug on older clients where two reactions were being shown when a user reacted to a chat message.

Old version of websocket push included UserID as a metadata field, and this was getting used in the reaction state updates. We changed the metadata fields to SenderUserID and ReceiverUserID but we should keep the old one around for backwards compatibility at least for a while.

How Has This Been Tested?

@dharit-tan dharit-tan requested a review from rickyrombo August 20, 2024 20:58
@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: c9b5ce3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tan dharit-tan requested a review from stereosteve August 20, 2024 21:00
@dharit-tan dharit-tan merged commit 49d2716 into main Aug 20, 2024
@dharit-tan dharit-tan deleted the rt-fix branch August 20, 2024 21:20
audius-infra pushed a commit that referenced this pull request Aug 21, 2024
Audius Protocol v0.6.173
52849e8 
[78897c4] [PAY-3355] Address link preview / unfurl QA items  (#9492) Raymond Jacobson
[a0e8fae] Remove rule 13 from blocking relay (#9496) Isaac Solo
[49d2716] [QA-1517] Include UserID in websocket metadata (#9497) Reed
[d19c208] [PAY-3309] Add is_hidden column to chat_member (#9483) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@stereosteve stereosteve Awaiting requested review from stereosteve

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dharit-tan @rickyrombo