-
Notifications
You must be signed in to change notification settings - Fork 126
[PAY-3359] Chat blast thread UI on sender side #9515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: fa25bcc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
| } | ||
| assert.Equal(t, "blast:69:follower_audience", chats[0].ChatID) | ||
| assert.Equal(t, "follower_audience", chats[1].ChatID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stereosteve i'm not entirely sure why the order changed, i logged the chats here:
2024/08/21 22:35:46 INFO REED chats !BADKEY="[{ChatID:D79jn:eYZmn CreatedAt:2024-08-22 02:34:16.079029 +0000 UTC LastMessage:{String:what up fam Valid:true} LastMessageAt:2024-08-22 02:34:26.079029 +0000 UTC LastMessageIsPlaintext:true InviteCode:x LastActiveAt:{Time:0001-01-01 00:00:00 +0000 UTC Valid:false} UnreadCount:1 ClearedHistoryAt:{Time:0001-01-01 00:00:00 +0000 UTC Valid:false} IsBlast:false Audience:{String: Valid:false} AudienceContentType:{String: Valid:false} AudienceContentID:{Int32:0 Valid:false}} {ChatID:follower_audience CreatedAt:2024-08-22 02:34:26.079029 +0000 UTC LastMessage:{String:what up fam Valid:true} LastMessageAt:2024-08-22 02:34:26.079029 +0000 UTC LastMessageIsPlaintext:true InviteCode: LastActiveAt:{Time:2024-08-22 02:34:26.079029 +0000 UTC Valid:true} UnreadCount:0 ClearedHistoryAt:{Time:0001-01-01 00:00:00 +0000 UTC Valid:false} IsBlast:true Audience:{String:follower_audience Valid:true} AudienceContentType:{String: Valid:false} AudienceContentID:{Int32:0 Valid:false}}]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LastMessageAt are the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As reed and I discussed... it's because getChat query doesn't actually filter on follower_audience... so other test data is coming back when it shouldn't. See steve todo below to fix this post-merge.
|
Preview this change https://demo.audius.co/rt-artist-blast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steve post-merge todos:
- combine the
getChat/getChatsquery - add "audience" filter to
getChat
n.b. Point two is why the test change was necessary... After adding "audience" filter it should go back to orig position.
|
Will merge this for now and @stereosteve will refactor afterwards. |
[46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [231571c] Fix relay container (#9528) Raymond Jacobson [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [9f07c22] Handle dupe comment transactions (#9511) Isaac Solo [1813960] route core console through nginx (#9514) alecsavvy
[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis
Description
chatIdfor blasts to not include "blast:", onlyconcat_ws(':', audience, audience_content_type, audience_content_id) as chat_idgetChatandgetMessagesworking for chat blastsaudience_content_typeandaudience_content_idonly when they are not nullis_blasttogetChatresponse (use this instead of "blast" prefix)Potentially annoying to have to include
is_blastin the request but I think this is the better pattern? open to ideas.How Has This Been Tested?
comms tests pass
Screen.Recording.2024-08-21.at.10.04.16.PM.mov