Skip to content

Update logic for allowing chat blast sending #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dharit-tan merged 1 commit into from
Aug 21, 2024
Merged

Update logic for allowing chat blast sending #9509

dharit-tan merged 1 commit into from
Aug 21, 2024

Conversation

@dharit-tan
Copy link
Contributor

@dharit-tan dharit-tan commented Aug 21, 2024

Description

tierNumber was coming out to 0 which was failing the boolean check.

How Has This Been Tested?

Local web stage

@dharit-tan dharit-tan requested a review from amendelsohn August 21, 2024 17:17
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 0f354c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

amendelsohn
amendelsohn approved these changes Aug 21, 2024
View reviewed changes
packages/web/src/pages/chat-page/components/ChatBlastCTA.tsx
const chatBlastTier = useRemoteVar(IntKeys.CHAT_BLAST_TIER_REQUIREMENT)
const userMeetsRequirements =
isVerified || (tierNumber && tierNumber >= chatBlastTier)
const userMeetsRequirements = isVerified || tierNumber >= chatBlastTier
Copy link
Contributor

@amendelsohn amendelsohn Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah undefined or null will fail the >= check so lgtm

edit: jk it passes for null >= 0 🤦 ty js

Copy link
Contributor Author

@dharit-tan dharit-tan Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out null >= 0 is true (thanks js) but tierNumber is of type number so i'm gonna trust that. we also have a ticket to restrict blast access on protocol side so if this check fails we'll still check there.

@audius-infra
Copy link
Collaborator

audius-infra commented Aug 21, 2024

Preview this change https://demo.audius.co/rt-chat-blast-cta

@dharit-tan dharit-tan merged commit 5349315 into main Aug 21, 2024
@dharit-tan dharit-tan deleted the rt-chat-blast-cta branch August 21, 2024 17:37
schottra added a commit that referenced this pull request Aug 22, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2918-migrate-trac…
0d8cfc2 
…k-endpoints-3

* origin/main:
  [QA-1499] Fix long usernames overflowing manager mode button (#9519)
  Run dashboard ci on common changes (#9521)
  Add react-router dependency (#9520)
  Move trpc to common (#9518)
  Active styles for web chat blasts (#9517)
  Add row and column props to flex (#9505)
  Handle dupe comment transactions (#9511)
  route core console through nginx (#9514)
  [C-4902] Add harmony checkbox  (#9510)
  Audius Protocol v0.6.174
  [PAY-3361] ChatBlastSelectAudienceScreen (#9502)
  [PAY-3228] Implement composer unfurl in mobile (#9504)
  [QA-1210] Fix popup scrolling issues (#9508)
  Update logic for allowing chat blast sending (#9509)
  [PAY-3362] Move link resolver to common hook (#9503)
  [PAY-3342] Chat upgrade handles prior blasts from both parties. (#9493)
  Add feature flag refresh (#9506)
  Audius Protocol v0.6.173
audius-infra pushed a commit that referenced this pull request Aug 24, 2024
Audius Client (Web and Mobile) v1.5.96
a10fd4c 
[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell
[c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell
[b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell
[eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis
[4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed
[72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers
[e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis
[46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott
[b957a52] Fix challenge api tx confirming (#9526) Isaac Solo
[6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo
[7f17c95] Hook up remixers count to web blast UI (#9523) Reed
[75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed
[93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler
[c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis
[7763deb] Add react-router dependency (#9520) Isaac Solo
[6de56bd] Move trpc to common (#9518) Dylan Jeffers
[76d4095] Active styles for web chat blasts (#9517) Reed
[3464a2a] Add row and column props to flex (#9505) Dylan Jeffers
[e6b1da1] [C-4902] Add harmony checkbox  (#9510) Dylan Jeffers
[0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn
[2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson
[b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis
[5349315] Update logic for allowing chat blast sending (#9509) Reed
[51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson
[45dc83d] Add feature flag refresh (#9506) Dylan Jeffers
[3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott
[78897c4] [PAY-3355] Address link preview / unfurl QA items  (#9492) Raymond Jacobson
[c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn
[e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn
[f3d7825] Remove listenUserId from chat api (#9479) Reed
[d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn
[adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo
[d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers
[b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott
[893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell
[7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson
[06a19e6] Remote config for chat blast tier requirement (#9490) Reed
[2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed
[1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler
[b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis
[1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler
[075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler
[bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo
[c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers
[5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed
[83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amendelsohn amendelsohn amendelsohn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dharit-tan @audius-infra @amendelsohn