[PAY-3228] Implement composer unfurl in mobile #9504

raymondjacobson · 2024-08-21T08:33:50Z

Description

Implement composer changes for message on mobile, following same patterns from web

Unfurl display text for tracks, collections, and users inline
Tracks and collections unfurl above with some content
Backspace deletes entire row
Unfurl in the messages themselves

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Staging on simulator, verified sharing of all content forms. Some potential concerns I want to test on app:

How responsive entering text is. It seemed a little slower than just the input on mobile, versus web which is near instant
Backspace behavior (see inline comment)

changeset-bot · 2024-08-21T08:33:54Z

⚠️ No Changeset found

Latest commit: 9ac511e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-08-21T08:47:41Z

Preview this change https://demo.audius.co/rj-pay-3219

audius-infra · 2024-08-21T16:47:57Z

Preview this change https://demo.audius.co/rj-pay-3219

raymondjacobson · 2024-08-21T18:53:30Z

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx

+        })
+
+        if (editValue) {
+          // Delay the deleting of the matched word because


this kinda sucks. couldn't figure out a better way to do this

audius-infra · 2024-08-21T19:05:24Z

Preview this change https://demo.audius.co/rj-pay-3219

dharit-tan · 2024-08-21T22:00:30Z

packages/mobile/src/components/core/UserGeneratedText.tsx

  const renderLink = useCallback(
    (text: string, match: Match) => (
-      <TextLink
+      <Link


might wanna double-check with dylan about this, i always forget which Link component is for which purpose.

this Link is defined in this file :) it uses TextLink under the hood

dharit-tan · 2024-08-21T22:01:12Z

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx

+    right: 40,
+    left: 0,
+    zIndex: 0,
+    paddingLeft: spacing(4) + 1,


woof but do wat u gotta do

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx

dharit-tan · 2024-08-21T22:02:26Z

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx

+            { maxHeight: hasCurrentlyPlayingTrack ? spacing(70) : spacing(80) }
+          ]}
+        >
+          <Text style={styles.overlayText}>


can we use the harmony built-in variants instead of explicit styles?

eg body variant should default to medium fontsize

unfortunately this is the Text from core, not harmony in this file, and originally I tried swapping it but this stuff is super sensitive to font-sizes, etc. I wanted to minimize changes there. This component needs a harmony refactor in general

dharit-tan · 2024-08-21T22:05:46Z

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx

-      autoCorrect
-    />
+    <Flex>
+      {trackId ? (


just double-checking that we ensure trackId and collectionId can't both be set at the same time in the common hook

they can be, but that's ok! it will show just a track in that case

dharit-tan

ty!

audius-infra · 2024-08-22T00:10:10Z

Preview this change https://demo.audius.co/rj-pay-3219

…k-endpoints-3 * origin/main: [QA-1499] Fix long usernames overflowing manager mode button (#9519) Run dashboard ci on common changes (#9521) Add react-router dependency (#9520) Move trpc to common (#9518) Active styles for web chat blasts (#9517) Add row and column props to flex (#9505) Handle dupe comment transactions (#9511) route core console through nginx (#9514) [C-4902] Add harmony checkbox (#9510) Audius Protocol v0.6.174 [PAY-3361] ChatBlastSelectAudienceScreen (#9502) [PAY-3228] Implement composer unfurl in mobile (#9504) [QA-1210] Fix popup scrolling issues (#9508) Update logic for allowing chat blast sending (#9509) [PAY-3362] Move link resolver to common hook (#9503) [PAY-3342] Chat upgrade handles prior blasts from both parties. (#9493) Add feature flag refresh (#9506) Audius Protocol v0.6.173

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

pull-request-size bot added the size/XL label Aug 21, 2024

raymondjacobson added 5 commits August 21, 2024 11:41

[PAY-3219] Auto format audius links in user generated text

5bd5b27

Update compose text box and button

8e1bdd1

[PAY-3228] Implement composer unfurl in mobile

a4841b5

Remove log

8f2fe23

Fix rename

97ff4d1

raymondjacobson force-pushed the rj-pay-3219 branch from 7d576d8 to 97ff4d1 Compare August 21, 2024 18:51

pull-request-size bot added size/L and removed size/XL labels Aug 21, 2024

raymondjacobson commented Aug 21, 2024

View reviewed changes

raymondjacobson requested a review from dharit-tan August 21, 2024 18:57

raymondjacobson assigned sliptype, Kyle-Shanks and amendelsohn Aug 21, 2024

dharit-tan reviewed Aug 21, 2024

View reviewed changes

packages/mobile/src/screens/chat-screen/ChatTextInput.tsx Outdated Show resolved Hide resolved

dharit-tan reviewed Aug 21, 2024

View reviewed changes

dharit-tan approved these changes Aug 21, 2024

View reviewed changes

Switch spacing

9ac511e

raymondjacobson enabled auto-merge (squash) August 22, 2024 00:01

raymondjacobson merged commit 2566eb8 into main Aug 22, 2024

raymondjacobson deleted the rj-pay-3219 branch August 22, 2024 00:34

[PAY-3228] Implement composer unfurl in mobile #9504

[PAY-3228] Implement composer unfurl in mobile #9504

Uh oh!

Conversation

raymondjacobson commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Aug 21, 2024

Uh oh!

audius-infra commented Aug 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

raymondjacobson commented Aug 21, 2024 •

edited

Loading

changeset-bot bot commented Aug 21, 2024 •

edited

Loading