Bump Lua 5.4.7 & sol 3.5.0#437
Closed
litelawliet wants to merge 1 commit into
Closed
Conversation
litelawliet
added a commit
to Overload-Technologies/Cargo
that referenced
this pull request
Apr 3, 2025
The color should be set in OnAwake instead of OnStart because another script is trying to access the light color in OnStart as well. Resulting in Undefined Behavior which breaks the final door enigma. Prior to Overload-Technologies/Overload#437 there was no issues even though we didn't have any script ordering, it was just luck.
Lua is now a static lib and is named "lua.lib". Sol is updated to current latest which is 3.5.0 at ThePhD/sol2@c1f95a7 In cargo: Currently having an issue getting the light color from "Key Light" in `FinalGateEnigma`, making impossible to finish the final enigma. We're setting the light color of `Key Light` in `OnStart`, we should have it set in `OnAwake` instead. We're trying to access the light color in `FinalGateEnigma` in `OnStart` function, thus leading to Undefined Behavior. The fact it was working previously is pure luck. Bumping Lua and Sol reavealed this UB due to getting the light color **and** setting the light color at the same time in `OnStart` functions, no ordering was guaranteed.
b1c0665 to
e8ff27b
Compare
Member
|
I've been trying to separate Dependencies/sol/Premake5.lua project "sol"
kind "SharedItems"
files { "**.hpp", "**.h", "**.lua" }
objdir (objoutdir .. "%{cfg.buildcfg}/%{prj.name}")
characterset ("MBCS")Dependencies/sol/include/sol.hpp // Content moved from "Dependencies/lua/include/sol.hpp"In includedirs {
-- ...
dependdir .. "lua/include", -- <-- added that
-- ...
}In Overload/Premake5.lua: group "Dependencies/Prebuilt"
-- other dependencies
include "../../Dependencies/sol" -- <-- added that
group ""Test commit including necessary changes to separate Sol from Lua: @litelawliet for vis. |
litelawliet
added a commit
to Overload-Technologies/Cargo
that referenced
this pull request
Apr 13, 2025
The color should be set in OnAwake instead of OnStart because another script is trying to access the light color in OnStart as well. Resulting in Undefined Behavior which breaks the final door enigma. Prior to Overload-Technologies/Overload#437 there was no issues even though we didn't have any script ordering, it was just luck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Here's a list of changes from Lua 5.3 to current 5.4.7:
https://www.lua.org/manual/5.4/readme.html#changes
Lua is now a static lib and is named
lua.lib, changes applies inOvEditorandOvGame's premake5 files.Sol also got updated to latest version available on GitHub (3.5.0—to get fixes for Lua 5.4), as of now : ThePhD/sol2@c1f95a7
In cargo:
Currently having an issue getting the light color from "Key Light" in
FinalGateEnigma, making impossible to finish the final enigma. We're setting the light color ofKey LightinOnStart, we should have it set inOnAwakeinstead. We're trying to access the light color inFinalGateEnigmainOnStartfunction, thus leading to Undefined Behavior. The fact it was working previously is pure luck. Bumping Lua and Sol reavealed this UB due to getting the light color and setting the light color at the same time inOnStartfunctions, no ordering was guaranteed.Cargo's fix Overload-Technologies/Cargo#13.