Fix "Gameplay_Key_Color.lua" script#13
Merged
Merged
Conversation
The color should be set in OnAwake instead of OnStart because another script is trying to access the light color in OnStart as well. Resulting in Undefined Behavior which breaks the final door enigma. Prior to Overload-Technologies/Overload#437 there was no issues even though we didn't have any script ordering, it was just luck.
litelawliet
changed the title
adriengivry
approved these changes
Apr 3, 2025
Member
|
@litelawliet I don't think you meant to close this one, but to merge it instead. Probably got closed automatically since you had the word "Fix" followed by a link to this PR on Overload's lua bump PR |
Contributor
Author
|
Oh yeah indeed, re-opening... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #12.
The color should be set in
OnAwakeinstead ofOnStartbecause another script is trying to access the light color inOnStartas well. Resulting in Undefined Behavior which breaks the final door enigma.Prior to Overload-Technologies/Overload#437 there was no issues even though we didn't have any script ordering, it was just luck.