feat: show tray menu only on right click#408
Merged
Merged
Conversation
Owner
|
Looks good! On macOS, left-click now toggles the window application, and right-click shows the menu, which I think is an acceptable behavior. Linux retains the original behavior where left and right click both show the menu. Thanks again for another contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the tray icon interaction so left click toggles the main window visibility, while the tray context menu is reserved for
right click.
Background
Discussed in #405.
The proposed behavior matches the more common Windows tray pattern:
Changes
.show_menu_on_left_click(false)to the tray icon builder.Testing
Tested manually on Windows:
Platform notes
As noted in #405:
show_menu_on_left_click(false)because tray/menu-bar click behavior is often controlled by the OS.