[helm] Enable pulling from private Docker registry#2692
Conversation
affo
force-pushed
the
la-pull-secrets
branch
from
4ac5e0d to
8cd11e5
Compare
| Image name | ||
| */}} | ||
| {{- define "fluss.image" -}} | ||
| {{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }} |
There was a problem hiding this comment.
If a user omits image.tag or sets it to empty, this would produce an invalid image reference like apache/fluss:. Maybe we need to add a fallback here.
| Image name | ||
| */}} | ||
| {{- define "fluss.image" -}} | ||
| {{- $image := printf "%s:%s" .Values.image.repository .Values.image.tag }} |
There was a problem hiding this comment.
If a user provides a purely numeric tag (e.g. tag: 1.0), printf "%s" in Helm may output apache/fluss:%!s(float64=1).
There was a problem hiding this comment.
what a catch! Partially addressed 🤝
affo
force-pushed
the
la-pull-secrets
branch
from
8cd11e5 to
8020252
Compare
|
@xx789633 the latest changes now address your doubts 🤝
For tag formatting, unfortunately, it is not possible to discriminate Wrapping the tag in quotes in YAML is left to the user 👍 I checked this behavior and it would be the same in Bitnami's charts. |
|
Looks good to me. |
|
LGTM overall. One more suggestion: Could you add documentation in |
Added instructions for using a private Docker registry and included image values reference.
|
I have appended a commit to document the private docker registry. Merging.... |
|
@xx789633 thanks for promptly acting on this one! |
* [helm] Enable pulling from private Docker registry Added instructions for using a private Docker registry and included image values reference. --------- Co-authored-by: xx789 <348448708@qq.com>
* [helm] Enable pulling from private Docker registry Added instructions for using a private Docker registry and included image values reference. --------- Co-authored-by: xx789 <348448708@qq.com>
* [helm] Enable pulling from private Docker registry (#2692) * [helm] Enable pulling from private Docker registry Added instructions for using a private Docker registry and included image values reference. --------- Co-authored-by: xx789 <348448708@qq.com> (cherry picked from commit 43f76a5) * [helm] Fix wrong resource name in coordinator sts (#2834) (cherry picked from commit 2c49fbc) * [helm] Add CI workflow to run Helm tests (#2777) * [helm] Add CI workflow to run Helm tests (cherry picked from commit dd181eb) * [Helm] Chart Component Configuration Isolation (#2472) * Helm Chart Component Configuration Isolation * Retrigger CI tests * Retriggering CI/CD build pipeline (cherry picked from commit d956e75) * [Helm] Revert Chart Component Configuration Isolation (#2472) (#2863) This reverts commit d956e75. (cherry picked from commit 8cd9a6f) * [helm] Enable SASL authentication configurations (#2506) (cherry picked from commit f7e4498) * [helm] Rewrite README to point to website docs (#2846) (cherry picked from commit aa5d166) * [helm][hotfix] Go template whitespace trimming caused exceptions (#2893) * [helm][hotfix] Go template whitespace trimming caused exceptions * Update and use without trimming (cherry picked from commit 22ece48) * [helm] Enable metrics reporting in helm charts (#2711) --- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> (cherry picked from commit 2b207a4) * [helm] Fix .helmignore to not package tests (#2847) (cherry picked from commit d4748f2) * [helm] Enable SASL authenticated connection to Zookeeper nodes (#2700) --- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> (cherry picked from commit bdbbbce) * [helm] Fix Zookeeper client config path (#3015) (cherry picked from commit e9bfd72) * [helm] Fix wrong resource name in coordinator sts (#3044) (cherry picked from commit 8df3873) * [helm] Add extraVolumes, extraVolumeMounts, initContainers (#3034) (cherry picked from commit 17f5400) --------- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com> Co-authored-by: xx789 <348448708@qq.com> Co-authored-by: Hemanth Savasere <hemanth.savasere@gmail.com>
* [helm] Enable pulling from private Docker registry Added instructions for using a private Docker registry and included image values reference. --------- Co-authored-by: xx789 <348448708@qq.com>
4 participants
Purpose
Linked issue: close #2691
Brief change log
images.registryimage.pullSecretsMakes it possible to use an alternate registry and use pull secrets to pull the image if the registry is private.
I favored the approach of adding pull secrets directly to STS and not in the service account for bigger flexibility as the user can still link another service account to pods while pull secrets are attached to pods.
Tests
No test introduced.
Would be good to add tests once this PR lands (introduces
helm unittest+ github workflow).API and Format
NO
Documentation
No new feature, it is already documented in the README.