Skip to content

[helm] Fix .helmignore to not package tests#2847

Merged
polyzos merged 1 commit into
apache:mainfrom
affo:la-fix-helmignore
Mar 26, 2026
Merged

[helm] Fix .helmignore to not package tests#2847
polyzos merged 1 commit into
apache:mainfrom
affo:la-fix-helmignore

Conversation

@affo
Copy link
Copy Markdown
Contributor

@affo affo commented Mar 11, 2026

Purpose

Linked issue: close #xxx

No issue created.

We were inadvertently packaging Helm tests as part of the charts.

Brief change log

Add tests as part of .helmignore

Tests

Manual test:

With the change:

helm package .
Successfully packaged chart and saved it to: /Users/lorenzo/repos/fluss/helm/fluss-0.10.0-incubating.tgz
➜  helm git:(la-fix-helmignore) ✗ tar tf ./fluss-0.10.0-incubating.tgz| grep tests
# nothing

Without

git stash
Saved working directory and index state WIP on la-fix-helmignore: 2f8cadad [fluss-client] Support Complex Data Types on the Java Typed API (Map and Array) (#2814)
➜  helm git:(la-fix-helmignore) ✗ helm package .                                  
Successfully packaged chart and saved it to: /Users/lorenzo/repos/fluss/helm/fluss-0.10.0-incubating.tgz
➜  helm git:(la-fix-helmignore) ✗ tar tf ./fluss-0.10.0-incubating.tgz| grep tests
fluss/tests/imagepullsecrets_test.yaml

API and Format

Documentation

Copy link
Copy Markdown
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@affo
Copy link
Copy Markdown
Contributor Author

affo commented Mar 12, 2026

@xx789633 would you be willing to review this one?
Is there a way to re-run CI?
Probably flakey

@affo affo force-pushed the la-fix-helmignore branch from 8984abd to cfe870f Compare March 17, 2026 09:53
@polyzos polyzos merged commit d4748f2 into apache:main Mar 26, 2026
10 of 11 checks passed
wxplovecc pushed a commit to tongcheng-elong/fluss that referenced this pull request Apr 17, 2026
wxplovecc pushed a commit to tongcheng-elong/fluss that referenced this pull request Apr 20, 2026
polyzos pushed a commit that referenced this pull request Apr 23, 2026
* [helm] Enable pulling from private Docker registry (#2692)

* [helm] Enable pulling from private Docker registry

Added instructions for using a private Docker registry and included image values reference.

---------

Co-authored-by: xx789 <348448708@qq.com>
(cherry picked from commit 43f76a5)

* [helm] Fix wrong resource name in coordinator sts (#2834)

(cherry picked from commit 2c49fbc)

* [helm] Add CI workflow to run Helm tests (#2777)

* [helm] Add CI workflow to run Helm tests

(cherry picked from commit dd181eb)

* [Helm] Chart Component Configuration Isolation (#2472)

* Helm Chart Component Configuration Isolation

* Retrigger CI tests

* Retriggering CI/CD build pipeline

(cherry picked from commit d956e75)

* [Helm] Revert Chart Component Configuration Isolation (#2472) (#2863)

This reverts commit d956e75.

(cherry picked from commit 8cd9a6f)

* [helm] Enable SASL authentication configurations (#2506)

(cherry picked from commit f7e4498)

* [helm] Rewrite README to point to website docs (#2846)

(cherry picked from commit aa5d166)

* [helm][hotfix] Go template whitespace trimming caused exceptions (#2893)

* [helm][hotfix] Go template whitespace trimming caused exceptions

* Update and use without trimming

(cherry picked from commit 22ece48)

* [helm] Enable metrics reporting in helm charts (#2711)

---

Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
(cherry picked from commit 2b207a4)

* [helm] Fix .helmignore to not package tests (#2847)

(cherry picked from commit d4748f2)

* [helm] Enable SASL authenticated connection to Zookeeper nodes (#2700)

---

Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
(cherry picked from commit bdbbbce)

* [helm] Fix Zookeeper client config path (#3015)

(cherry picked from commit e9bfd72)

* [helm] Fix wrong resource name in coordinator sts (#3044)

(cherry picked from commit 8df3873)

* [helm] Add extraVolumes, extraVolumeMounts, initContainers (#3034)

(cherry picked from commit 17f5400)

---------

Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
Co-authored-by: xx789 <348448708@qq.com>
Co-authored-by: Hemanth Savasere <hemanth.savasere@gmail.com>
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants