Skip to content

Improve com.alibaba.fluss.flink.catalog.* test code coverage#989

Merged
wuchong merged 11 commits into
apache:mainfrom
caozhen1937:test_package_catalog
Jun 10, 2025
Merged

Improve com.alibaba.fluss.flink.catalog.* test code coverage#989
wuchong merged 11 commits into
apache:mainfrom
caozhen1937:test_package_catalog

Conversation

@caozhen1937
Copy link
Copy Markdown
Contributor

@caozhen1937 caozhen1937 commented Jun 4, 2025

Purpose

Linked issue: close #970

Brief change log

Tests

API and Format

Documentation

@caozhen1937 caozhen1937 force-pushed the test_package_catalog branch 2 times, most recently from e37ee8f to e5f2f8d Compare June 4, 2025 08:24
wuchong
wuchong reviewed Jun 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caozhen1937 , I only have one concern related to the SPI.

Comment thread ...ink/fluss-flink-common/src/test/java/com/alibaba/fluss/flink/catalog/FlinkCatalogITCase.java
Comment thread .../fluss-flink-common/src/test/java/com/alibaba/fluss/flink/catalog/FlinkTableFactoryTest.java Outdated
@MehulBatra MehulBatra mentioned this pull request Jun 8, 2025
Merged
@wuchong
Copy link
Copy Markdown
Member

wuchong commented Jun 8, 2025

Hi @caozhen1937 , as discussed in #929 (comment) with @MehulBatra , could you try to see whether this PR fix the coverage of FlinkCatalogOptions and FlinkCatalog (verify by removing them from the jacoco)? If not, @MehulBatra can help to cover them in another PR.

@caozhen1937 caozhen1937 force-pushed the test_package_catalog branch from e896bf5 to 3157d9b Compare June 9, 2025 08:54
@caozhen1937
Copy link
Copy Markdown
Contributor Author

caozhen1937 commented Jun 9, 2025 •
edited
Loading

Hi @caozhen1937 , as discussed in #929 (comment) with @MehulBatra , could you try to see whether this PR fix the coverage of FlinkCatalogOptions and FlinkCatalog (verify by removing them from the jacoco)? If not, @MehulBatra can help to cover them in another PR.

Hi @wuchong @MehulBatra , My tests doesn‘t fix the FlinkCatalogOptions test coverage. ( I just invoke it, test coverage is 0.66). And FlinkCatalog test coverage already merged into main.

I think after #989 merged, @MehulBatra can coverage #optionalOptions() test.

@caozhen1937 caozhen1937 force-pushed the test_package_catalog branch from 3157d9b to 82b004e Compare June 9, 2025 12:24
wuchong
wuchong reviewed Jun 9, 2025
View reviewed changes
Comment thread fluss-test-coverage/pom.xml
<exclude>com.alibaba.fluss.flink.source.*
</exclude>
<exclude>
com.alibaba.fluss.flink.catalog.FlinkCatalogOptions
Copy link
Copy Markdown
Member

@wuchong wuchong Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you already fixed FlinkCatalogOptions for #929?

Copy link
Copy Markdown
Contributor Author

@caozhen1937 caozhen1937 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuchong Yes, I just want to test again.

@wuchong wuchong merged commit 3b96888 into apache:main Jun 10, 2025
4 checks passed
@loserwang1024 loserwang1024 mentioned this pull request Jun 17, 2025
Closed
2 tasks
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
@caozhen1937 @ZmmBigdata
[test] Improve com.alibaba.fluss.flink.catalog.* test code coverage (a…
0bafe83 
…pache#989)
polyzos pushed a commit to polyzos/fluss that referenced this pull request Aug 30, 2025
@caozhen1937 @polyzos
[test] Improve com.alibaba.fluss.flink.catalog.* test code coverage (a…
0f1b205 
…pache#989)
polyzos pushed a commit to HZY-Wade/fluss that referenced this pull request Aug 31, 2025
@caozhen1937 @polyzos
[test] Improve com.alibaba.fluss.flink.catalog.* test code coverage (a…
aade7e7 
…pache#989)
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
@caozhen1937
[test] Improve com.alibaba.fluss.flink.catalog.* test code coverage (a…
9ad23b4 
…pache#989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuchong wuchong wuchong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

improve com.alibaba.fluss.flink.catalog.* test code coverage

2 participants

@caozhen1937 @wuchong