Followup to #368 - Emscripten Docker Image

[trzecieu]

Hi, I can I'm a part of organization on docker. Thanks.

Looks like there are 2 projects: emscripten/emscripten-ci and emscripten/emsdk - I thought that we will go under emscripten/emscripten name.

If everything is fine let me know so that I can start building and pushing images 1.38.40... (fastcomp + upstream flavors).

Here is my small story to complete:
- [ ] build and publish all current versions
- [ ] create dockerhub project description
- [ ] update trzeci/emscripten descriptions to advertise using the official image
- [x] hook building image CI (starting with own Jenkins)
update: changed as #372 (comment)

I see that hooking building Docker Image with my current infrastructure as a temporary solution. Ideally this should be hooked after the official build is published.

Issue created for visibility after #368, let me know what you think about plan above and if I have a green light.
CC: @sbc100, @kripken

Best regards,
Piotr

[kripken]

Looks like there are 2 projects: emscripten/emscripten-ci and emscripten/emsdk - I thought that we will go under emscripten/emscripten name.

Oh, I thought @sbc100 suggested "emscripten/emsdk" for this image - maybe I misunderstood? I don't have a preference either way, but emsdk does make sense I think.

[sbc100]

I did agree that emscripten/emscripten was ok, but I'm ok with emscripten/emsdk too. in some say it does make more sense.

[sbc100]

Regarding CI, please stick to cricleci so that we only have one CI system.

[sbc100]

Otherwise sounds great! Thanks for working on this.

[Squareys]

@sbc100 @trzecieu Hey guys, I highly appreciate your efforts of moving @trzecieu's Dockerfiles to an official image!
What's the status on this?

PS:

It looks like building docker images on Circle CI is well described here and should be triggered by a GitHub workflow whenever emscripten-releases-tags.txt changes on master. @RReverser attempted to do the transition, but reportedly still needs access to emsdk.

[sbc100]

I think the status is that we'd love to see it move forward but its been stalled for a few months. If yourself or @trzecieu wants to get this going agin it would be more than welcome!

[sbc100]

Also, lets drop that fastcomp image in just ship llvm upstream.

[trzecieu]

Hi @Squareys, @sbc100 : Thank you for poking and being interested in help, and in general what's the status. I appreciate this.
I had to put on hold all hobbyist projects due family reasons for a while, just started doing some work last week and this is something that I'd like to finalize.

What does it mean in practice? This week I'll investigate why some last build are failing on my CI and process collected issues.
And actually help is appreciated, especially in the way how should we hook building docker image to current CI of emscripten-core.

I'm open for cooperation and feedback.

[Squareys]

@trzecieu @sbc100 I'd be happy to volunteer for the setup on Circle CI, but I am unsure of how the process is here.
I guess I can start off by creating the Circle CI config for a fork and then contribute the dotfile through a PR to this repo?

[Squareys]

Since the Circle CI config changes have been merged, what's left to do is to:

• Set CircleCI DOCKER_PASS and DOCKER_USER on the emsdk Circle CI account (@haraldreingruber mentioned @kripken might have access to the credentials)
• Build and publish existing tags, as @trzecieu mentioned. He would need to be added to the emscripten/emsdk docker hub (His docker user is trzeci].

[trzecieu]

About point nr 2, an interesting part is that I'm a member of the emscripten org, team emsdk - maybe there is some missing settings allowing me to push.

[kripken]

About point 1, what exactly should I do? (bear in mind I am not familiar with docker... what values should those fields have, to start with?)

About point 2, I see the emscripten/emsdk repo, but am not sure how to give @trzecieu additional permissions there. I don't see an option to add a user as a collaborator, and in the permissions tab I can make an "emsdk" team with read+write permissions but I don't see how to add people to that team...

[trzecieu]

Hi!
About point 2, Just tested and it looks I can push image to emscripten/emsdk That's great! I will check on pushing couple of images.
About point 1, It's possible to generate an access token (https://hub.docker.com/settings/security) for this purpose that can be used instead of password on CircleCI - also it's easy to revoke if something goes wrong.

---

I'm updating my fork and will check if I can mimic the setup quickly