This repository was archived by the owner on Apr 4, 2024. It is now read-only.
fix: revert changes from TypedEvents#1600
Merged
Vvaradinov merged 6 commits intomainfrom Jan 11, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
+ Coverage 68.19% 68.31% +0.11%
==========================================
Files 110 110
Lines 10087 10087
==========================================
+ Hits 6879 6891 +12
+ Misses 2801 2793 -8
+ Partials 407 403 -4
|
fedekunze
approved these changes
Jan 11, 2023
Contributor
fedekunze
left a comment
There was a problem hiding this comment.
LGTM, although there's no need to remove the proto files
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
This PR reverts the changes made in #1544 as they are breaking the RPCs. Further changes will be made and tested in #1592 but for the time being to unblock immediate work this is being reverted.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)