fix(action-sheet): remove the height shift on press#16862
Merged
Conversation
- this changes the border into a linear gradient background image which allows us to avoid the height decrease on press and have the same border as the fill color fixes #16790
…am/ionic into fix-action-sheet-border
only applies the translucent and backdrop filter if it is supported by the browser
Member
Author
|
This should be good to merge if the build passes + screenshot looks good. It has been approved by Ben. We may want to iterate on the translucency in the future but it is pretty close to native. |
Member
Author
|
Update: after discussing with Adam we discovered the compareScreenshot was stopping the tests when the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This changes the border into a linear gradient background image which allows us to avoid the height decrease on press and have the same border as the background color when pressed.
#ffffffby defaultFixes #16790
References #16715
masterfix-action-sheet-border