Skip to content

fix(action-sheet): remove the height shift on press#16862

Merged
brandyscarney merged 21 commits into
masterfrom
fix-action-sheet-border
Jan 10, 2019
Merged

fix(action-sheet): remove the height shift on press#16862
brandyscarney merged 21 commits into
masterfrom
fix-action-sheet-border

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Dec 21, 2018

Copy link
Copy Markdown
Member

Short description of what this resolves:

This changes the border into a linear gradient background image which allows us to avoid the height decrease on press and have the same border as the background color when pressed.

  • changes border color to match native
  • removes the negative margin shift on press
  • makes the cancel button #ffffff by default
  • combines e2e tests back to basic

Fixes #16790
References #16715

master fix-action-sheet-border
localhost_3333_src_components_action-sheet_test_basic iphone 6_7_8 1 localhost_3333_src_components_action-sheet_test_basic iphone 6_7_8
screen shot 2018-12-21 at 3 31 00 pm screen shot 2018-12-21 at 3 25 57 pm
screen shot 2018-12-21 at 3 26 25 pm screen shot 2018-12-21 at 3 25 14 pm

screen shot 2019-01-09 at 10 46 49 am

- this changes the border into a linear gradient background image which allows us to avoid the height decrease on press and have the same border as the fill color

fixes #16790
@ionitron-bot ionitron-bot Bot added the package: core @ionic/core package label Dec 21, 2018
@brandyscarney

Copy link
Copy Markdown
Member Author

This should be good to merge if the build passes + screenshot looks good. It has been approved by Ben. We may want to iterate on the translucency in the future but it is pretty close to native.

@brandyscarney

Copy link
Copy Markdown
Member Author

Update: after discussing with Adam we discovered the compareScreenshot was stopping the tests when the expect failed. So we are moving the tests out to where there is only one compare per test. This PR needs to be updated for Action Sheet still, and then we can look at the remaining ones that have multiple compares separately.

@brandyscarney brandyscarney merged commit 82457d8 into master Jan 10, 2019
@brandyscarney brandyscarney deleted the fix-action-sheet-border branch January 10, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

action sheet: height is shrinking on press / activate

1 participant