Terminal Icon picker weird placement

[benibenj]

The terminal icon picker is positioned at the far top of the window. This looks a bit weird as the top border of the widget is not visible. I would have expected the widget to be placed bellow the command center.

[Tyriar]

Code pointer:

vscode/src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts

Line 60 in 191a248

position: {

[sossost]

hello! @Tyriar I'm sossost, a new contributor. I would like to solve this problem.

Which is the best solution
modifying the top border of the widget so that it is not cut off, or positioning the widget below the command center?

[Tyriar]

@sossost ideally we would position it below the command center when it's triggered via the command palette, or near the terminal tab if it's triggered from there.

[tisilent]

Wow.

[Narendherraj]

@Tyriar Like @abhijit-chikane has expressed his concern in the PR raised should we probably change the position of the terminal icon colour change tab as well if not it might look weird where one shows the position on bottom and the other on top .