Skip to content

Fix terminal icon picker placement#281275

Merged
meganrogge merged 2 commits intomicrosoft:mainfrom
milanchahar:fix-terminal-icon-picker
Dec 17, 2025
Merged

Fix terminal icon picker placement#281275
meganrogge merged 2 commits intomicrosoft:mainfrom
milanchahar:fix-terminal-icon-picker

Conversation

@milanchahar
Copy link
Contributor

Fixes #211083. The terminal icon picker was using 'quickPickTop' offset which caused it to overlay the title bar when the Command Center is enabled. This change updates it to use 'activeContainerOffset.top' to ensure it appears below the title bar.

@meganrogge meganrogge self-requested a review December 17, 2025 22:33
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you!

Image

@meganrogge meganrogge enabled auto-merge (squash) December 17, 2025 22:34
@meganrogge meganrogge merged commit a04b198 into microsoft:main Dec 17, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal Icon picker weird placement

3 participants