fix selections not included in implicit#276604
Merged
justschen merged 1 commit intorelease/1.106from Nov 10, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
mjbvz
approved these changes
Nov 10, 2025
roblourens
reviewed
Nov 10, 2025
| const contextArr = this.getAttachedContext(sessionResource); | ||
|
|
||
| if (this.implicitContext?.enabled && this.implicitContext?.value && this.configurationService.getValue<boolean>('chat.implicitContext.suggestedContext')) { | ||
| if ((this.implicitContext?.enabled && this.implicitContext?.value) || (this.implicitContext && !URI.isUri(this.implicitContext.value) && this.configurationService.getValue<boolean>('chat.implicitContext.suggestedContext'))) { |
Member
There was a problem hiding this comment.
Is !isUri correct here, because it will then always include StringChatContextValue?
Member
There was a problem hiding this comment.
Side note, do we still need this setting?
Collaborator
Author
There was a problem hiding this comment.
i tried it out and i think it's fine, but yeah it's a revert from what it was before we added the new value type, so i'm not 100% sure
and yes, we probably do not need this setting anymore.
Member
There was a problem hiding this comment.
You tried it with a custom context provider?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release branch fix for #276599
(which just reverts #275432)