fix: memory leak in status bar#282246
Merged
jrieken merged 35 commits intomicrosoft:mainfrom Dec 16, 2025
Merged
Conversation
…s disabled" This reverts commit f04c75b.
…atee Bring back model picker for inline chat (release)
…#276070) Changes defaul of triggerCommandOnProviderChange to false. Fixes microsoft#276065
… (microsoft#276073) SCM - fix rendering issue with incoming/outgoing changes nodes
…ng-schema-url-cp tools: fix wrong data passed to tool schema uri
Fixes microsoft#276167 Workaround until we get proper fix as part of microsoft#274403
get hidden chat terminal count to update (microsoft#276163)
…41712340f6f31b8c19fd289 Port 276167 to release
Filter subagent and todo tools from subagent requests
…ChatController.ts
…xtensionPoints.ts
…ser/terminalChatService.ts
jrieken
requested changes
Dec 15, 2025
jrieken
approved these changes
Dec 16, 2025
aiday-mar
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in extension host status bar items. Generated by GitHub Copilot.
When a status bar item is added with the
$setEntrymethod, a disposable is being added:However it doesn't seem to be removed in
$disposeEntryBefore
When opening and closing an image editor 97 times, which registers 3 status bar items, the number of
MainThreadStatusBar.$setEntryfunctions grows by 291 (97*3).After
When opening and closing an image editor 97 times, the number of
MainThreadStatusBar.$setEntryfunctions stays constant.