Skip to content

FrontFacingNode: Fix frontFacing if used material.flatShading#30828

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-flatShading
Mar 30, 2025
Merged

FrontFacingNode: Fix frontFacing if used material.flatShading#30828
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-flatShading

Conversation

@sunag

@sunag sunag commented Mar 30, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #30823 (comment)

Description

Fix frontFacing if used material.flatShading.

@sunag sunag added this to the r176 milestone Mar 30, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.08
78.29
336.08
78.29
+0 B
+0 B
WebGPU 532.77
148.04
532.74
148.03
-25 B
-11 B
WebGPU Nodes 532.24
147.94
532.21
147.93
-25 B
-12 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.09
112.16
465.09
112.16
+0 B
+0 B
WebGPU 604.41
164.01
604.38
164
-25 B
-9 B
WebGPU Nodes 559.39
153.46
559.37
153.45
-25 B
-9 B

@sunag sunag marked this pull request as ready for review March 30, 2025 21:14
@sunag sunag merged commit 62bb685 into mrdoob:dev Mar 30, 2025
@sunag sunag deleted the dev-fix-flatShading branch March 30, 2025 21:15
@WestLangley

Copy link
Copy Markdown
Collaborator

@sunag WebGPU is looking better! :-)

There are still console errors for both backends when the geometry has tangents, a normal map is present, and flat shading is true.

If it is not an easy fix, I can file a bug report if you wish.

@Mugen87

Mugen87 commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator

If you share a fiddle, I can take a look!

@sunag

sunag commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator Author

Hi! Thanks @WestLangley. @Mugen87 I fixed here, I will post this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants