WebGPUTextureUtils: Fix check layerUpdates property#33075
Merged
Conversation
sunag
changed the title
layerUpdates properties
sunag
changed the title
layerUpdates propertieslayerUpdates property
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Feb 26, 2026
| } else if ( texture.isArrayTexture || texture.isDataArrayTexture || texture.isData3DTexture ) { | ||
|
|
||
| if ( texture.layerUpdates.size > 0 ) { | ||
| if ( texture.layerUpdates && texture.layerUpdates.size > 0 ) { |
Collaborator
There was a problem hiding this comment.
I think that's because Data3DTexture hasn't layerUpdates.
Does it make sense to add this property in this class as well?
/cc @ahaensler
Collaborator
There was a problem hiding this comment.
Merging for now. We can still add the property and refactor if there is a use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #33072
Description
This should fix Textures that do not have the property so it doesn’t fail the
.lengthcheck.