feat: use Distinct instead of Project for profile metadata queries#5959
Merged
Conversation
Contributor
Author
|
"make go/lint" failed with "arrow.Record is deprecated" is not related to this change, |
brancz
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Project()withDistinct()inGetProfileMetadataMappingsandGetProfileMetadataLabelsmethods to ensure unique results and improvequery performance by eliminating duplicate stacktrace and label entries.
This change will not affect correctness as GetProfileMetadataMappings
and GetProfileMetadataLabels also have deduplicate logic.
This change helps reduce 100+ million rows from the underlying database, just like #5921