Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: stellar/stellar-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v23.2.1
Choose a base ref
...
head repository: stellar/stellar-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v23.3.0
Choose a head ref
  • 16 commits
  • 67 files changed
  • 8 contributors

Commits on Nov 19, 2025

  1. CI: upgrade workflows to use macos-15(*) rather than macos-13 (#2276)

    ### What
    
    Upgrade workflows to use `macos-15-*` rather than `macos-13`
    
    ### Why
    
    1. It's about to be deprecated: [announcement
    🔗](actions/runner-images#13046)
    2. It's already making the CI fail: [example run
    🔗](https://github.com/stellar/stellar-cli/actions/runs/19081484092/job/54516597745?pr=2275)
    
    ### Notes on Runner Compatibility
    
    After extensive testing across macOS runner types:
    
    | Runner | Result | Notes |
    |:--|:--:|:--|
    | ✅ **macos-15-large** | ✅ **Passes** | Stable with full setup. |
    | ✅ **macos-14** | ✅ **Passes** | Works consistently. |
    | 🟠 **macos-15-intel** | ⚠️ **Intermittent** | Suitable for lighter
    setups but fails under heavier load — `-large` is usually more stable. |
    | 🟠 **macos-15** | ⚠️ **It depends** | Does **not** support nested
    virtualization (required by Lima/QEMU), so cannot be used in some
    setups. |
    
    ### ⚠️ Disabled Job
    
    I couldn't make the ledger-emulator.yml workflow succeed for macos
    despite many attempts, so it was temporarily disabled, to be re-added in
    #2299.
    marcelosalloum authored Nov 19, 2025
    Configuration menu
    Copy the full SHA
    1e12cb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2025

  1. Replace custom data_into_key with to_key method (#2301)

    ### What
    Replace the custom data_into_key function with LedgerEntry's built-in
    to_key method and remove the 86-line helper function along with its
    associated imports.
    
      ### Why
    The stellar-xdr library now provides a native to_key method on
    LedgerEntry, eliminating the need for a custom implementation that
    manually converts each LedgerEntryData variant to its corresponding
    LedgerKey.
    leighmcculloch authored Nov 21, 2025
    Configuration menu
    Copy the full SHA
    352db56 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2025

  1. fix: generate help for recursive custom types (#1593)

    Fixes #1588 
    
    Refactors generated help example and usage notes to accommodate self-referencing custom types. 
    ---------
    
    Co-authored-by: elizabethengelman <4752801+elizabethengelman@users.noreply.github.com>
    Co-authored-by: Nando Vieira <me@fnando.com>
    3 people authored Nov 24, 2025
    Configuration menu
    Copy the full SHA
    96ad868 View commit details
    Browse the repository at this point in the history
  2. Update rpc client to get_events by passing topics as [TopicFilter] (#…

    …2292)
    
    ### What
    
    closes #2021
    
    related rpc-client pr:
    stellar/rs-stellar-rpc-client#57
    
    Updates the topic filter structure that is being passed to the rpc
    server `getEvents` method, to align with it's expected API.
    
    The GetEventsRequest, from the rpc server, is expecting the topics to be
    an array of TopicFilters, and a TopicFilter is an array of
    SegmentFilters. So it is expecting an array of arrays.
    
    ### Why
    We are currently just passing in a segment filter, without nesting it in
    an array of arrays, and are seeing an error when doing so.
    elizabethengelman authored Nov 24, 2025
    Configuration menu
    Copy the full SHA
    a8e1d07 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2025

  1. Update md-gen alias to account for doc-gen being its own crate (#2298)

    Updates the `md-gen` alias to specify that `doc-gen` is it's own
    package, similar to `make docs`.
    elizabethengelman authored Nov 25, 2025
    Configuration menu
    Copy the full SHA
    d869f24 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2025

  1. Configuration menu
    Copy the full SHA
    e7dd939 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2025

  1. Configuration menu
    Copy the full SHA
    ccd211c View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2025

  1. Configuration menu
    Copy the full SHA
    fc2cc45 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2025

  1. Configuration menu
    Copy the full SHA
    0125540 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82212a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b0bc2bd View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2025

  1. Pass 'quiet' value through to config.sign (#2300)

    ### What
    closes #1840 
    
    Changes the `config.sign` signature to also accept a boolean "quiet"
    value.
    
    ### Why
    
    So we can pass that value through to `sign_with.sign_tx_env` and respect
    the `quiet` config when printing.
    
    ### Known limitations
    
    n/a
    elizabethengelman authored Dec 3, 2025
    Configuration menu
    Copy the full SHA
    c49acab View commit details
    Browse the repository at this point in the history
  2. Integration testing updates (#2302)

    ### What
    
    Minor improvements to RPC tests, patching secure store
    intermittent CI failures, and allowing all container types to run on
    release PR updates.
    
    ### Why
    
    Failure rate of RPC tests is ~30% in CI pipelines, and a few tests have
    remained ignored without issues
    
    ### Known limitations
    
    Slightly increase CI minutes as now 3 container types will run RPC tests
    on release PRs as well
    mootz12 authored Dec 3, 2025
    Configuration menu
    Copy the full SHA
    f90f573 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2025

  1. Configuration menu
    Copy the full SHA
    3fba9af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d09254 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2025

  1. Configuration menu
    Copy the full SHA
    08473ac View commit details
    Browse the repository at this point in the history
Loading