Skip to content

fix: remove types: ['node'] from generated tsconfig#15709

Merged
Rich-Harris merged 5 commits into
mainfrom
copilot/fix-svelte-check-incremental-issue
Jun 17, 2026
Merged

fix: remove types: ['node'] from generated tsconfig#15709
Rich-Harris merged 5 commits into
mainfrom
copilot/fix-svelte-check-incremental-issue

Conversation

Copilot AI commented Apr 11, 2026 •
edited by teemingc
Loading

Copy link
Copy Markdown
Contributor

The generated .svelte-kit/tsconfig.json hardcodes types: ['node'], which produces TS2688 when @types/node isn't installed. This silently causes svelte-check --incremental to skip standalone .ts files (e.g. +server.ts, utility modules), missing type errors that non-incremental mode catches.

  • Remove types: ['node'] from the generated compilerOptions in write_tsconfig.js

Without types, TypeScript falls back to its default behavior: auto-include all @types/* packages present in node_modules. Users with @types/node installed see no change; users without it no longer get a phantom error that breaks incremental checking.

EDIT: I might want to add a failing test for this

@changeset-bot

changeset-bot Bot commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 48da121

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc
fix: remove types: ['node'] from generated tsconfig to avoid errors w…
aa61d1f 
…hen @types/node is not installed

Agent-Logs-Url: https://github.com/sveltejs/kit/sessions/48ebb06e-0f17-45da-8115-b50acaf6d293

Co-authored-by: teemingc <54401897+teemingc@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix svelte-check incremental mode to include standalone .ts files fix: remove types: ['node'] from generated tsconfig Apr 11, 2026
Copilot AI requested a review from teemingc April 11, 2026 17:28
@teemingc teemingc marked this pull request as ready for review April 12, 2026 16:58
@dummdidumm

dummdidumm commented Apr 12, 2026

Copy link
Copy Markdown
Member

I believe in TS 6/7 the default is the empty array so this would break it for users of that version. We might have to check whether the types exist and add the array or not depending on the outcome

@teemingc

teemingc commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I believe in TS 6/7 the default is the empty array so this would break it for users of that version. We might have to check whether the types exist and add the array or not depending on the outcome

That’s true. But, we didn’t have this before moving to TypeScript 6, and those who chose to upgrade would have had to deal with a bunch of breaking changes anyway. Therefore, I’m wondering if it’s better for users to add the types array themselves in the user config. It would be a little weird if only node was automatically added.

teemingc
teemingc previously approved these changes May 6, 2026
View reviewed changes
@teemingc teemingc dismissed their stale review May 6, 2026 04:19

does nothing

@svelte-docs-bot

svelte-docs-bot Bot commented May 6, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-15709-svelte.vercel.app/

@teemingc teemingc mentioned this pull request May 15, 2026
Open
@teemingc teemingc requested a review from dummdidumm May 19, 2026 09:59
@Rich-Harris Rich-Harris merged commit 860b3c7 into main Jun 17, 2026
26 checks passed
@Rich-Harris Rich-Harris deleted the copilot/fix-svelte-check-incremental-issue branch June 17, 2026 20:41
@github-actions github-actions Bot mentioned this pull request Jun 17, 2026
Merged
Rich-Harris pushed a commit that referenced this pull request Jun 18, 2026
@github-actions
Version Packages (#16062)
4c9b8f1 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/enhanced-img@0.11.0

### Minor Changes


- feat: export `EnhancedImgAttributes` type
([#15649](#15649))


### Patch Changes


- fix: exclude imports with `?` character from transformation
([#15617](#15617))
## @sveltejs/kit@2.66.0

### Minor Changes


- feat: precompress prerendered `.md` and `.mdx` files
([#15893](#15893))


- feat: warn the user when they forget to make boolean inputs optional
in their form schemas
([#15804](#15804))


### Patch Changes


- fix: blur active element before component update during navigation so
that blur/focusout handlers fire while old component data is still valid
([#15452](#15452))


- fix: ensure `base` is available from `$service-worker` during
development ([#15882](#15882))


- fix: use correct relative asset paths when rendering an error page for
a missing `__data.json` request
([#15884](#15884))


- fix: preserve active `for await` consumers across `query.live`
reconnects ([#16022](#16022))


- fix: settle `query.live` reconnect promise on all exit paths,
preventing `invalidateAll()` from deadlocking when a live query is
offline or interrupted
([#16022](#16022))


- fix: preserve last value when a `query.live` stream completes without
yielding on reconnect
([#16022](#16022))


- fix: remove `types: ['node']` from generated tsconfig to avoid errors
when `@types/node` is not installed
([#15709](#15709))


- fix: prefer pages over endpoints when prerendering
([#16076](#16076))


- fix: restore snapshots after afterNavigate callbacks
([#16066](#16066))


- fix: support `ws:`/`wss:` and `trusted-types-eval` for CSP sources
([#15938](#15938))


- fix: omit empty `file` inputs from remote form data
([#15898](#15898))


- fix: fail early if a route with `+page` and `+server` is marked as
prerenderable ([#16075](#16075))


- fix: wait a tick before resetting forms
([#15805](#15805))


- fix: `preflight` schemas apply correctly when chained before `for`
([#15863](#15863))


- fix: blank page in SPA mode when root layout `load()` throws
([#15798](#15798))


- fix: pass all unknown options from the `sveltekit` Vite plugin through
to `vite-plugin-svelte`
([#16010](#16010))
## @sveltejs/adapter-node@5.5.5

### Patch Changes


- fix: bundle entrypoints alongside app code
([#16069](#16069))


- fix: log the actual adapter-node listening address
([#15899](#15899))

- Updated dependencies
[[`63f1b0b`](63f1b0b),
[`1dbff3f`](1dbff3f),
[`961ba01`](961ba01),
[`d2e108c`](d2e108c),
[`d2e108c`](d2e108c),
[`d2e108c`](d2e108c),
[`860b3c7`](860b3c7),
[`f8c842c`](f8c842c),
[`d3aa5fe`](d3aa5fe),
[`0dd7659`](0dd7659),
[`03e9f66`](03e9f66),
[`57b7b7b`](57b7b7b),
[`4eabadc`](4eabadc),
[`6fbf2b6`](6fbf2b6),
[`276744d`](276744d),
[`8740132`](8740132),
[`f430a68`](f430a68),
[`1c7a8dc`](1c7a8dc)]:
  - @sveltejs/kit@2.66.0
## @sveltejs/adapter-vercel@6.3.4

### Patch Changes


- fix: prevent missing immutable assets from being cached as 404s for a
year ([#16077](#16077))

- Updated dependencies
[[`63f1b0b`](63f1b0b),
[`1dbff3f`](1dbff3f),
[`961ba01`](961ba01),
[`d2e108c`](d2e108c),
[`d2e108c`](d2e108c),
[`d2e108c`](d2e108c),
[`860b3c7`](860b3c7),
[`f8c842c`](f8c842c),
[`d3aa5fe`](d3aa5fe),
[`0dd7659`](0dd7659),
[`03e9f66`](03e9f66),
[`57b7b7b`](57b7b7b),
[`4eabadc`](4eabadc),
[`6fbf2b6`](6fbf2b6),
[`276744d`](276744d),
[`8740132`](8740132),
[`f430a68`](f430a68),
[`1c7a8dc`](1c7a8dc)]:
  - @sveltejs/kit@2.66.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jun 18, 2026
Open
huskas-2189 pushed a commit to huskas-2189/Bookmark that referenced this pull request Jun 20, 2026
@huskas-2189
chore(deps): update dependency @sveltejs/kit to v2.66.0 (#126)
e06d530 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@sveltejs/kit](https://svelte.dev) ([source](https://github.com/sveltejs/kit/tree/HEAD/packages/kit)) | [`2.65.1` → `2.66.0`](https://renovatebot.com/diffs/npm/@sveltejs%2fkit/2.65.1/2.66.0) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@sveltejs%2fkit/2.66.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@sveltejs%2fkit/2.65.1/2.66.0?slim=true) |

---

### Release Notes

<details>
<summary>sveltejs/kit (@&#8203;sveltejs/kit)</summary>

### [`v2.66.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2660)

[Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.65.2...@sveltejs/kit@2.66.0)

##### Minor Changes

- feat: precompress prerendered `.md` and `.mdx` files ([#&#8203;15893](sveltejs/kit#15893))

- feat: warn the user when they forget to make boolean inputs optional in their form schemas ([#&#8203;15804](sveltejs/kit#15804))

##### Patch Changes

- fix: blur active element before component update during navigation so that blur/focusout handlers fire while old component data is still valid ([#&#8203;15452](sveltejs/kit#15452))

- fix: ensure `base` is available from `$service-worker` during development ([#&#8203;15882](sveltejs/kit#15882))

- fix: use correct relative asset paths when rendering an error page for a missing `__data.json` request ([#&#8203;15884](sveltejs/kit#15884))

- fix: preserve active `for await` consumers across `query.live` reconnects ([#&#8203;16022](sveltejs/kit#16022))

- fix: settle `query.live` reconnect promise on all exit paths, preventing `invalidateAll()` from deadlocking when a live query is offline or interrupted ([#&#8203;16022](sveltejs/kit#16022))

- fix: preserve last value when a `query.live` stream completes without yielding on reconnect ([#&#8203;16022](sveltejs/kit#16022))

- fix: remove `types: ['node']` from generated tsconfig to avoid errors when `@types/node` is not installed ([#&#8203;15709](sveltejs/kit#15709))

- fix: prefer pages over endpoints when prerendering ([#&#8203;16076](sveltejs/kit#16076))

- fix: restore snapshots after afterNavigate callbacks ([#&#8203;16066](sveltejs/kit#16066))

- fix: support `ws:`/`wss:` and `trusted-types-eval` for CSP sources ([#&#8203;15938](sveltejs/kit#15938))

- fix: omit empty `file` inputs from remote form data ([#&#8203;15898](sveltejs/kit#15898))

- fix: fail early if a route with `+page` and `+server` is marked as prerenderable ([#&#8203;16075](sveltejs/kit#16075))

- fix: wait a tick before resetting forms ([#&#8203;15805](sveltejs/kit#15805))

- fix: `preflight` schemas apply correctly when chained before `for` ([#&#8203;15863](sveltejs/kit#15863))

- fix: blank page in SPA mode when root layout `load()` throws ([#&#8203;15798](sveltejs/kit#15798))

- fix: pass all unknown options from the `sveltekit` Vite plugin through to `vite-plugin-svelte` ([#&#8203;16010](sveltejs/kit#16010))

### [`v2.65.2`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2652)

[Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.65.1...@sveltejs/kit@2.65.2)

##### Patch Changes

- fix: throw an error when prerendering a root +server.js that returns a non-HTML response ([#&#8203;15994](sveltejs/kit#15994))

- fix: decode base64-serialized fetch bodies before caching them for client-side replay ([#&#8203;16034](sveltejs/kit#16034))

- fix: correctly access explicit dynamic public environment variables from prerendered pages and service workers ([#&#8203;16024](sveltejs/kit#16024))

- fix: allow `preloadCode` to be called during initial page load ([#&#8203;16028](sveltejs/kit#16028))

- fix: send `cache-control: private, no-store` on remote function responses so personalized query results can never be cached by shared caches ([#&#8203;16020](sveltejs/kit#16020))

- fix: preserve the HTTP status and error body when a remote function request fails in transport (e.g. a 401/403 from a `handle` hook), instead of reporting a generic 500 ([#&#8203;16021](sveltejs/kit#16021))

- fix: avoid loading universal nodes during build analysis when the app uses a hash router ([#&#8203;16042](sveltejs/kit#16042))

- fix: correctly serve client entry during development when using the pnpm global virtual store ([#&#8203;16045](sveltejs/kit#16045))

- fix: normalize path separators when comparing config ([#&#8203;16037](sveltejs/kit#16037))

- fix: ensure `building` resolves correctly to allow avoiding build-time explicit environment variable validation ([#&#8203;16058](sveltejs/kit#16058))

- fix: prevent unhandled promise rejections when remote function failures are consumed via `current`/`error` instead of `await` ([#&#8203;16018](sveltejs/kit#16018))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled because a matching PR was automerged previously.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yMjAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjIyMC4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Reviewed-on: https://codeberg.org/huskas-2189/Bookmark/pulls/126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

@teemingc teemingc teemingc left review comments

@dummdidumm dummdidumm Awaiting requested review from dummdidumm

Assignees

@teemingc teemingc

Copilot code review Copilot

Labels

types / typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

svelte-check --incremental skips standalone .ts files

4 participants

@dummdidumm @teemingc @Rich-Harris