fix: don't emit the unused bundle and stylesheet files when using bundleStrategy: 'inline'#16025
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2852496 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ndleStrategy: 'inline'`
71ffff6 to
47051f3
Compare
teemingc
reviewed
Jun 12, 2026
teemingc
requested changes
Jun 12, 2026
teemingc
left a comment
Member
There was a problem hiding this comment.
We ought to avoid creating a new test app for this and instead reuse the one at packages/kit/test/apps/options-3 which is already configured to inline the app.
teemingc
reviewed
Jun 12, 2026
teemingc
reviewed
Jun 12, 2026
teemingc
reviewed
Jun 12, 2026
teemingc
reviewed
Jun 12, 2026
teemingc
reviewed
Jun 12, 2026
Merged
teemingc
pushed a commit
that referenced
this pull request
Jun 14, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.65.1 ### Patch Changes - fix: avoid importing the Vite development client code into builds with a non-standard `NODE_ENV` ([#16023](#16023)) - fix: don't emit the unused bundle and stylesheet files when using `bundleStrategy: 'inline'` ([#16025](#16025)) - fix: reset queries before navigating when `invalidateAll` is set ([#16014](#16014)) - fix: regression in loading assets for absolute path apps ([#16026](#16026)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
bundleStrategy: 'inline', the bundle and stylesheet are written to_app/immutableeven though their content is inlined into the page, so the build ships a full copy of the app that nothing ever loads. In the default template that roughly doubles the output size, and a service worker will happily precache the dead files too.This deletes both files (and the bundle sourcemap if present) once their content has been captured for inlining, and filters anything that no longer exists out of the
$service-workerbuild list.version.jsonstays, since the version checker can still fetch it at runtime. Of the unused files listed in the issue,env.jsno longer reproduces on current main, so these two were the ones left. I went with deleting the files after the build rather than suppressing their emission inside it, sincefind_depsand the manifest plumbing still need the entries to exist, but open to a different route if preferred.The
options-3app now has a service worker and a stylesheet, and its build-mode tests assert the inlined files are gone from_app/immutable(including sourcemaps), the service worker build list is clean, andversion.jsonsurvives. The emitted-files assertions fail on main.Found this one while working on #16024 and digging through how the client build decides what to emit.
Fixes #13700
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits