Skip to content

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers#24073

Merged
mcollovati merged 1 commit into
mainfrom
issues/24055-options_application_properties
Apr 9, 2026
Merged

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers#24073
mcollovati merged 1 commit into
mainfrom
issues/24055-options_application_properties

Conversation

@mcollovati
Copy link
Copy Markdown
Collaborator

@mcollovati mcollovati commented Apr 3, 2026

TypeScriptBootstrapModifier implementations (e.g., Copilot) need access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add withApplicationConfiguration to Options and property accessor
methods (getApplicationStringProperty, getApplicationBooleanProperty)
that return Optional.empty() when configuration is unavailable (build
time). Wire ApplicationConfiguration from DevModeInitializer.

Fixes #24055

@github-actions github-actions Bot added the +0.1.0 label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Test Results

 1 388 files  +1   1 388 suites  +1   1h 24m 31s ⏱️ + 2m 29s
 9 942 tests +4   9 871 ✅ +4  71 💤 ±0  0 ❌ ±0 
10 415 runs  +4  10 335 ✅ +4  80 💤 ±0  0 ❌ ±0 

Results for commit a7501f2. ± Comparison against base commit 9ea2d00.

♻️ This comment has been updated with latest results.

@mcollovati
feat: expose application properties via Options for `TypeScriptBoot…
a7501f2 
…strapModifier` consumers

`TypeScriptBootstrapModifier` implementations (e.g., Copilot) need access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`, `getApplicationBooleanProperty`)
that return `Optional.empty()` when configuration is unavailable (build
time). Wire `ApplicationConfiguration` from `DevModeInitializer`.

Fixes #24055
@mcollovati mcollovati force-pushed the issues/24055-options_application_properties branch from 0ff4e43 to a7501f2 Compare April 7, 2026 14:08
@mcollovati mcollovati marked this pull request as ready for review April 7, 2026 14:08
@github-actions github-actions Bot added +0.0.1 and removed +0.1.0 labels Apr 7, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

Quality Gate Passed Quality Gate passed

Issues
Image 0 New issues
Image 0 Accepted issues

Measures
Image 0 Security Hotspots
Image 0.0% Coverage on New Code
Image 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mcollovati mcollovati added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 727464d Apr 9, 2026
31 checks passed
@mcollovati mcollovati deleted the issues/24055-options_application_properties branch April 9, 2026 14:08
@vaadin-bot vaadin-bot mentioned this pull request May 4, 2026
Merged
@vaadin-bot
Copy link
Copy Markdown
Collaborator

vaadin-bot commented May 4, 2026

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 727464d
error: could not apply 727464d... feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Copy Markdown
Collaborator

vaadin-bot commented May 4, 2026

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 727464d
error: could not apply 727464d... feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Copy Markdown
Collaborator

vaadin-bot commented May 4, 2026

Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 727464d
error: could not apply 727464d... feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vaadin-bot added a commit that referenced this pull request May 4, 2026
@vaadin-bot @mcollovati
feat: expose application properties via Options for `TypeScriptBoot…
e771943 
…strapModifier` consumers (#24073) (CP: 25.1) (#24248)

This PR cherry-picks changes from the original PR #24073 to branch 25.1.
---
#### Original PR description
> `TypeScriptBootstrapModifier` implementations (e.g., Copilot) need
access
> to application properties to conditionally modify bootstrap
TypeScript.
> Currently, the Copilot script is injected in dev mode regardless of
> whether Copilot is enabled in the project configuration.
> 
> Add `withApplicationConfiguration` to `Options` and property accessor
> methods (`getApplicationStringProperty`,
`getApplicationBooleanProperty`)
> that return `Optional.empty()` when configuration is unavailable
(build
> time). Wire `ApplicationConfiguration` from `DevModeInitializer`.
> 
> Fixes #24055

Co-authored-by: Marco Collovati <marco@vaadin.com>
caalador pushed a commit that referenced this pull request May 6, 2026
@mcollovati
feat: expose application properties via Options for `TypeScriptBoot…
addcba0 
…strapModifier` consumers (#24073) (CP: 25.0) (#24252)

`TypeScriptBootstrapModifier` implementations (e.g., Copilot) need
access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`,
`getApplicationBooleanProperty`)
that return `Optional.empty()` when configuration is unavailable (build
time). Wire `ApplicationConfiguration` from `DevModeInitializer`.

Fixes #24055
@vaadin-bot vaadin-bot mentioned this pull request May 6, 2026
Merged
caalador pushed a commit that referenced this pull request May 6, 2026
@mcollovati
feat: expose application properties via Options for `TypeScriptBoot…
ace9144 
…strapModifier` consumers (#24073) (CP: 24.10) (#24267)

`TypeScriptBootstrapModifier` implementations (e.g., Copilot) need
access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`,
`getApplicationBooleanProperty`)
that return `Optional.empty()` when configuration is unavailable (build
time). Wire `ApplicationConfiguration` from `DevModeInitializer`.

Fixes #24055
vaadin-bot added a commit that referenced this pull request May 6, 2026
@vaadin-bot @mcollovati
feat: expose application properties via Options for `TypeScriptBoot…
7d2c456 
…strapModifier` consumers (#24073) (CP: 24.10) (#24267) (CP: 24.9) (#24271)

This PR cherry-picks changes from the original PR #24267 to branch 24.9.
---
#### Original PR description
> `TypeScriptBootstrapModifier` implementations (e.g., Copilot) need
access
> to application properties to conditionally modify bootstrap
TypeScript. Currently, the Copilot script is injected in dev mode
regardless of whether Copilot is enabled in the project configuration.
> 
> Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`,
> `getApplicationBooleanProperty`)
> that return `Optional.empty()` when configuration is unavailable
(build time). Wire `ApplicationConfiguration` from `DevModeInitializer`.
> 
> Fixes #24055

Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caalador caalador caalador approved these changes

Assignees

No one assigned

Labels

cherry-picked-24.9 cherry-picked-24.10 cherry-picked-25.0 cherry-picked-25.1 target/24.9 target/24.10 target/25.0 Cherry-pick to 25.0 branch target/25.1 +0.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add copilotEnabled option for TypeScriptBootstrapModifier consumers

3 participants

@mcollovati @vaadin-bot @caalador