Skip to content

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 25.0)#24252

Merged
caalador merged 1 commit into
25.0from
cherry/cherrypick-24073-to-25.0
May 6, 2026
Merged

feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 25.0)#24252
caalador merged 1 commit into
25.0from
cherry/cherrypick-24073-to-25.0

Conversation

@mcollovati
Copy link
Copy Markdown
Collaborator

TypeScriptBootstrapModifier implementations (e.g., Copilot) need access
to application properties to conditionally modify bootstrap TypeScript. Currently, the Copilot script is injected in dev mode regardless of whether Copilot is enabled in the project configuration.

Add withApplicationConfiguration to Options and property accessor methods (getApplicationStringProperty,
getApplicationBooleanProperty)
that return Optional.empty() when configuration is unavailable (build time). Wire ApplicationConfiguration from DevModeInitializer.

Fixes #24055

…strapModifier` consumers (#24073)

`TypeScriptBootstrapModifier` implementations (e.g., Copilot) need
access
to application properties to conditionally modify bootstrap TypeScript.
Currently, the Copilot script is injected in dev mode regardless of
whether Copilot is enabled in the project configuration.

Add `withApplicationConfiguration` to `Options` and property accessor
methods (`getApplicationStringProperty`,
`getApplicationBooleanProperty`)
that return `Optional.empty()` when configuration is unavailable (build
time). Wire `ApplicationConfiguration` from `DevModeInitializer`.

Fixes #24055
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Test Results

1 319 files  +1  1 319 suites  +1   1h 14m 41s ⏱️ -2s
9 417 tests +4  9 350 ✅ +4  67 💤 ±0  0 ❌ ±0 
9 880 runs  +8  9 805 ✅ +8  75 💤 ±0  0 ❌ ±0 

Results for commit 3ea05d1. ± Comparison against base commit f7e8ed8.

@mcollovati mcollovati changed the title feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 25.0) May 4, 2026
@mshabarov mshabarov requested a review from caalador May 5, 2026 07:50
@caalador caalador merged commit addcba0 into 25.0 May 6, 2026
30 checks passed
@caalador caalador deleted the cherry/cherrypick-24073-to-25.0 branch May 6, 2026 04:37
@vaadin-bot
Copy link
Copy Markdown
Collaborator

Hi @mcollovati and @caalador, when i performed cherry-pick to this commit to 24.10, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick addcba0
error: could not apply addcba0... feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 25.0) (#24252)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Copy Markdown
Collaborator

Hi @mcollovati and @caalador, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick addcba0
error: could not apply addcba0... feat: expose application properties via Options for TypeScriptBootstrapModifier consumers (#24073) (CP: 25.0) (#24252)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants