fix: pin pnpm version when invoking via npx#24293
Merged
Merged
Conversation
getSuitablePnpm() invoked `npx --yes --quiet pnpm`, letting npx resolve whatever it considered latest (or whatever was cached) rather than the DEFAULT_PNPM_VERSION constant. Pass `pnpm@<DEFAULT_PNPM_VERSION>` so the installed version matches the constant.
|
mcollovati
reviewed
May 8, 2026
| // happens to resolve as latest | ||
| pnpmCommand = getNpmCliToolExecutable(BuildTool.NPX, "--yes", | ||
| "--quiet", "pnpm"); | ||
| "--quiet", "pnpm@" + DEFAULT_PNPM_VERSION); |
Collaborator
Member
Author
There was a problem hiding this comment.
I didn't remember that npx pnpm@5 might run pnpm 6... but I don't see how this would make it any worse. Without any version number, npx can basically pick any pnpm version. With the version number, it should not be able to pick older versions
mcollovati
approved these changes
May 8, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.2.0-alpha7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSuitablePnpm() invoked
npx --yes --quiet pnpm, letting npx resolve whatever it considered latest (or whatever was cached) rather than the DEFAULT_PNPM_VERSION constant. Passpnpm@<DEFAULT_PNPM_VERSION>so the installed version matches the constant.