vlib: use defer(fn) { syntax where appropriate#25653
Merged
Merged
Conversation
StunxFS
changed the title
defer(en) { syntax where appropriatedefer(fn) { syntax where appropriate
spytheman
reviewed
Nov 4, 2025
| mut res := 0 | ||
| $if trace_ssl ? { | ||
| defer { | ||
| defer(fn) { |
Contributor
There was a problem hiding this comment.
Why does this need to be changed?
Because it is inside a the comptime $if scope, or for some other reason?
Contributor
Author
There was a problem hiding this comment.
Exactly, defer uses the comptime $if scope, in a future PR I will make defer use the parent scope instead of that one.
spytheman
reviewed
Nov 4, 2025
spytheman
reviewed
Nov 4, 2025
spytheman
reviewed
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of PR #25639.
Merge after PR #25651.This PR makes use of the syntax
defer(fn) {where appropriate.v -scoped-defer -o v cmd/vworks!