Conversation
Fix unsuded imports, import order. Renamed entrypoint script plugins.py trying to import "plugins." module causing pylint error.
…o feature/pylint
* Unnecessary use of a comprehension * Unused variables * singleton-comparison * Using built-in python vars * Unnecessary "else" after "raise" * Unnecessary "elif" after "return" * Using deprecated methods
6 tasks
Silence for now, refactor this function in the future. Fix pylint R0914: Too many local variables (23/15) (too-many-locals) See: #327
Silence for now, refactor this function in the future. > R0914: Too many local variables (36/15) (too-many-locals) > R0912: Too many branches (19/12) (too-many-branches) > R0915: Too many statements (104/50) (too-many-statements) See: #328
Silence for now, refactor this function in the future. > R0914: Too many local variables (22/15) (too-many-locals) > R0915: Too many statements (59/50) (too-many-statements) See: #329
arm4b
requested review from
PhillypHenning,
ccapell,
dylan-bitovi and
mickmcgrath13
Contributor
Author
|
The overall cosmetic pylint refactoring is done and pylint check is now succeeding and is part of the CI. However, some parts of the codebase will need more structural rework like extracting some huge functions into classes.
^^ these would be also good first issues/PRs easier to tackle in between the tasks. |
PhillypHenning
requested changes
Oct 20, 2022
PhillypHenning
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Pylint https://pylint.pycqa.org/en/latest/ as a static code analyser for the Python codebase, for quick spotting the common mistakes, errors and enhancing the python coding standards in a minimal automated way.
With #297, closes #271
Quick run: