-
Notifications
You must be signed in to change notification settings - Fork 917
Fixes #8314 : Missing domainsfolder Setting for Payara Services Configuration #8542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enterprise/payara.common/src/org/netbeans/modules/payara/common/actions/DebugAction.java
Outdated
Show resolved
Hide resolved
|
@jGauravGupta it would be great if you could finish this. There are two issues, that might be affected by this: #8555 and #8314, it would be good to fix this regression. |
|
@jGauravGupta would you mind checking this suggestion: The idea here:
Feel free to merge with your changes and please squash into a single commit. |
|
Thanks @mbien and @matthiasblaesing for review. |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed one location (see inline). With that added this is good to merge. Thank you.
enterprise/payara.common/src/org/netbeans/modules/payara/common/actions/StopServerAction.java
Outdated
Show resolved
Hide resolved
… Configuration Fixes apache#8314 : Missing domainsfolder Setting for Payara Services Configuration Replaced string comparison with Boolean.TRUE.toString().equals(...) by Boolean.parseBoolean(...) Update enterprise/payara.common/src/org/netbeans/modules/payara/common/actions/StopServerAction.java Co-Authored-By: Matthias Bläsing <[email protected]>
matthiasblaesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me. Thanks for the updates. Please merge once CI is green.
|
Same thing on my Mac OS nb 26. Saw same on prior NB versions. Since I have pulled prior projects many times over the years when installer of new NB asks to use prior projects, maybe my project properties are really incorrect. Not sure if NB fixes them with every new release automatically. But anyway, I have Payara Server 6.2025.6 and jboss-eap-8.0 servers installed. But my project run parameters drop down will only show Payara, jboss wildly is not in the drop down and can't be selected. Because I can't change run parameters to jboss, deploy/run/ect to not work for this project. I must go to finder and manually copy the web app from the project to jboss, then app will appear on NB server tab under jboss server and I can launch it from there. Is there a separate ticket for this issue? |
Fixes Payara Server Configuration Issue by Restoring
domainsfolderSupport in NetBeansThis PR addresses an issue introduced in NetBeans 25+ where the
domainsfolderattribute was unintentionally removed from Payara Server service configurations. As a result, users experienced broken server setups after accessing the service properties in the UI, since the domains directory could no longer be resolved.