Skip to content

Conversation

@jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented May 28, 2025

Fixes Payara Server Configuration Issue by Restoring domainsfolder Support in NetBeans

This PR addresses an issue introduced in NetBeans 25+ where the domainsfolder attribute was unintentionally removed from Payara Server service configurations. As a result, users experienced broken server setups after accessing the service properties in the UI, since the domains directory could no longer be resolved.

@jGauravGupta jGauravGupta added this to the NB27 milestone May 28, 2025
@jGauravGupta jGauravGupta added Java EE/Jakarta EE [ci] enable enterprise job Regression This used to work! labels May 28, 2025
@mbien mbien linked an issue May 28, 2025 that may be closed by this pull request
@matthiasblaesing
Copy link
Contributor

@jGauravGupta it would be great if you could finish this. There are two issues, that might be affected by this: #8555 and #8314, it would be good to fix this regression.

@jGauravGupta jGauravGupta marked this pull request as ready for review June 9, 2025 12:31
@matthiasblaesing
Copy link
Contributor

@jGauravGupta would you mind checking this suggestion:

matthiasblaesing@064cd0d

The idea here:

  • apply the cleanup in all affected places
  • use the existing code in PayaraInstance.java and don't duplicate the logic

Feel free to merge with your changes and please squash into a single commit.

@jGauravGupta
Copy link
Contributor Author

jGauravGupta commented Jun 13, 2025

Thanks @mbien and @matthiasblaesing for review.

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed one location (see inline). With that added this is good to merge. Thank you.

… Configuration

Fixes apache#8314 : Missing domainsfolder Setting for Payara Services Configuration

Replaced string comparison with Boolean.TRUE.toString().equals(...) by Boolean.parseBoolean(...)

Update enterprise/payara.common/src/org/netbeans/modules/payara/common/actions/StopServerAction.java

Co-Authored-By: Matthias Bläsing <[email protected]>
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thanks for the updates. Please merge once CI is green.

@jGauravGupta jGauravGupta merged commit 0c7a9bb into apache:master Jul 1, 2025
31 checks passed
@jrgamber
Copy link

Same thing on my Mac OS nb 26. Saw same on prior NB versions.
I must start/stop payara from terminal
./asadmin start-domain --debug domain1
Then refresh payara server and then can deploy app and server application drop down in server lets me start app in browser. Also, all debugging is active.

Since I have pulled prior projects many times over the years when installer of new NB asks to use prior projects, maybe my project properties are really incorrect. Not sure if NB fixes them with every new release automatically. But anyway, I have Payara Server 6.2025.6 and jboss-eap-8.0 servers installed. But my project run parameters drop down will only show Payara, jboss wildly is not in the drop down and can't be selected. Because I can't change run parameters to jboss, deploy/run/ect to not work for this project. I must go to finder and manually copy the web app from the project to jboss, then app will appear on NB server tab under jboss server and I can launch it from there. Is there a separate ticket for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java EE/Jakarta EE [ci] enable enterprise job Regression This used to work!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payara Issues in NB25 - Starting Server / Specifying JDK

4 participants