Skip to content

improve decoration rendering efficiency #145751

Closed
#149486
Closed
improve decoration rendering efficiency#145751
#149486
Assignees
Tyriar
Labels
bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersperfterminal-findRelating the terminal's find widgetterminal-shell-integrationShell integration infrastructure, command decorations, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeeded
Milestone
May 2022

Description

@Tyriar
Daniel Imms (Tyriar)
opened on Mar 22, 2022

Testing #145629

Could repro this slowness by filling the buffer and then searching for a single letter, this is on a 12th gen i7 (fast modern CPU):

image

A similar thing happens when pressing enter in this state since we don't do any diffing, just clear and re-render.

Ideas to explore:

  • Move from rendering each decoration to calculating colored zones which merge similar rectangles into the same zone and render them
  • If the buffer is full, explore shifting the texture up depending on how much scrolling occurs (might be tricky to get right)

Activity

  1. ImageDaniel Imms (Tyriar)
    added
    bugIssue identified by VS Code Team member as probable bug
    upstreamIssue identified as 'upstream' component related (exists outside of VS Code)
    perf
    terminal-findRelating the terminal's find widget
    terminal-shell-integrationShell integration infrastructure, command decorations, etc.
    on Mar 22, 2022
  2. ImageDaniel Imms (Tyriar)
    added this to the Backlog milestone on Mar 22, 2022
  3. ImageDaniel Imms (Tyriar)
    assigned
    Daniel Imms (Tyriar)
    and
    Megan Rogge (meganrogge)
    on Mar 22, 2022

  4. Tyriar commented on Mar 22, 2022

    @Tyriar
    Daniel Imms (Tyriar)
    on Mar 22, 2022
    ContributorAuthor

    xterm.js issue: xtermjs/xterm.js#3703

  5. ImageDaniel Imms (Tyriar)
    added
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    on Mar 22, 2022
  6. ImageDaniel Imms (Tyriar)
    added
    upstream-issue-fixedThe underlying upstream issue has been fixed
    on Apr 1, 2022

  7. Tyriar commented on Apr 1, 2022

    @Tyriar
    Daniel Imms (Tyriar)
    on Apr 1, 2022
    ContributorAuthor

    After update no more overlap problems:

    image

  8. ImageDaniel Imms (Tyriar)
    closed this as completedin 1735a8fon Apr 1, 2022
  9. ImageVS Code Issue Triage Bot (vscode-triage-bot)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on Apr 1, 2022

  10. 15 remaining items

  11. ImageMegan Rogge (meganrogge)
    removed
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    upstream-issue-fixedThe underlying upstream issue has been fixed
    on Apr 29, 2022
  12. ImageMegan Rogge (meganrogge)
    changed the title [-]Optimize rendering of decorations in terminal overview ruler[/-] [+]refreshDecorations is slow[/+] on May 5, 2022
  13. ImageDaniel Imms (Tyriar)
    unassigned
    Megan Rogge (meganrogge)
    on May 5, 2022
  14. ImageMegan Rogge (meganrogge)
    changed the title [-]refreshDecorations is slow[/-] [+]improve decoration rendering efficiency[/+] on May 9, 2022
  15. ImageDaniel Imms (Tyriar)
    added a commit that references this issue on May 9, 2022

    Only create decoration elements when they are actually rendered

    b7c0332
  16. ImageDaniel Imms (Tyriar)
    added
    upstream-issue-linkedThis is an upstream issue that has been reported upstream
    upstream-issue-fixedThe underlying upstream issue has been fixed
    on May 13, 2022
  17. ImageDaniel Imms (Tyriar)
    added a commit that references this issue on May 13, 2022

    Update xterm and make term find styles consistent with editor

    99e15df
  18. ImageDaniel Imms (Tyriar)
    closed this as completedin #149486on May 13, 2022
  19. ImageVS Code Bot (vscodenpa)
    added
    unreleasedPatch has not yet been released in VS Code Insiders
    insiders-releasedPatch has been released in VS Code Insiders
    and removed
    unreleasedPatch has not yet been released in VS Code Insiders
    on May 13, 2022
  20. ImageDaniel Imms (Tyriar)
    added
    verifiedVerification succeeded
    on Jun 3, 2022
  21. Imagegithub-actions
    locked and limited conversation to collaborators on Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buginsiders-releasedPatch has been released in VS Code Insidersperfterminal-findRelating the terminal's find widgetterminal-shell-integrationShell integration infrastructure, command decorations, etc.upstreamIssue identified as 'upstream' component related (exists outside of VS Code)upstream-issue-fixedThe underlying upstream issue has been fixedupstream-issue-linkedThis is an upstream issue that has been reported upstreamverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions