rustc_ast_lowering: track implicit Self via explicit flag instead of name - #163531

paradoxicalguy · 2026-09-30T09:38:46Z

View all comments

fixes #163457
& added a ui regression test for the reported reproducer.

r? @bjorn3

paradoxicalguy · 2026-09-30T10:58:16Z

(≧ω≦)

paradoxicalguy · 2026-10-01T08:25:39Z

cc @aerooneqq

paradoxicalguy · 2026-10-01T19:33:34Z

hey @bjorn3 mind taking a look at this when you get a sec?

bjorn3 · 2026-10-02T11:27:42Z

Don't know anything about this code.

r? compiler

petrochenkov · 2026-10-02T11:57:53Z

@bors delegate=aerooneqq
Could you review this?

rust-bors · 2026-10-02T11:57:55Z

Unknown argument "Could". Did you mean to use @bors tryorreview``? Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

petrochenkov · 2026-10-02T11:58:33Z

@bors delegate=aerooneqq

rust-bors · 2026-10-02T11:58:36Z

✌️ @aerooneqq, you can now approve this pull request!

If @petrochenkov told you to "r=me" after making some further change, then please make that change and post @bors r=petrochenkov.

View changes since this delegation.

rustbot · 2026-10-02T12:50:35Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

paradoxicalguy · 2026-10-03T03:37:35Z

@rustbot ready

Enselic · 2026-10-03T10:26:48Z

r? aerooneqq

rustbot · 2026-10-03T10:26:53Z

Error: Failed to set assignee to aerooneqq: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

Enselic · 2026-10-03T10:27:11Z

r? petrochenkov

paradoxicalguy · 2026-10-03T11:14:47Z

oh sorry, i forgot @aerooneqq
ready to review now

aerooneqq · 2026-10-05T08:39:01Z

Seems OK, can you change commit message and PR title as the fix idea has changed.
@rustbot author

…name

aerooneqq · 2026-10-05T10:34:15Z

@bors r=petrochenkov

rust-bors · 2026-10-05T10:34:18Z

📌 Commit f20f0c4 has been tentatively approved by petrochenkov

It will be put into the queue for this repository once PR CI succeeds.

paradoxicalguy · 2026-10-05T10:35:32Z

yay╰(°▽°)╯

@bjorn3

…, r=petrochenkov rustc_ast_lowering: track implicit Self via explicit flag instead of name fixes rust-lang#163457 & added a ui regression test for the reported reproducer. r? @bjorn3

…uwer Rollup of 5 pull requests Successful merges: - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name) - #163785 (Bump Windows CI LLVM to 22.1.8) - #163646 (Get `inputs_hir` directly from `decl`) - #163733 (Fix extra spaces in integer format_into docs) - #163787 (moves rustc_legacy_const_generics checks into attribute parsing)

rust-bors · 2026-10-05T16:50:54Z

⌛ Testing commit f20f0c4 with merge 307e6c7...

Workflow: https://github.com/rust-lang/rust/actions/runs/37343956829

@bjorn3

…enkov rustc_ast_lowering: track implicit Self via explicit flag instead of name fixes #163457 & added a ui regression test for the reported reproducer. r? @bjorn3

@bjorn3

…, r=petrochenkov rustc_ast_lowering: track implicit Self via explicit flag instead of name fixes rust-lang#163457 & added a ui regression test for the reported reproducer. r? @bjorn3

JonathanBrouwer · 2026-10-05T17:17:47Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-10-05T17:17:59Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/37343956829

The next pull request likely to be tested is #163827.

…uwer Rollup of 12 pull requests Successful merges: - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name) - #160915 ([rustdoc] Fix how `Deref` items is handled.) - #163364 (make semicolon_in_expressions_from_non_local_macros not report-in-deps) - #163770 (document the rustc_comptime attribute) - #163780 (Skip optional asserts in SsaRangePropagation) - #163785 (Bump Windows CI LLVM to 22.1.8) - #163796 (continue crashes tests `-Znext-solver` work) - #163646 (Get `inputs_hir` directly from `decl`) - #163733 (Fix extra spaces in integer format_into docs) - #163773 (Update GitHub Actions to v26) - #163787 (moves rustc_legacy_const_generics checks into attribute parsing) - #163810 (Fix an issue for clippy's `search_is_some` with the next-solver)

…uwer Rollup of 11 pull requests Successful merges: - #163364 (make semicolon_in_expressions_from_non_local_macros not report-in-deps) - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name) - #163770 (document the rustc_comptime attribute) - #163780 (Skip optional asserts in SsaRangePropagation) - #163785 (Bump Windows CI LLVM to 22.1.8) - #163796 (continue crashes tests `-Znext-solver` work) - #163646 (Get `inputs_hir` directly from `decl`) - #163733 (Fix extra spaces in integer format_into docs) - #163773 (Update GitHub Actions to v26) - #163787 (moves rustc_legacy_const_generics checks into attribute parsing) - #163810 (Fix an issue for clippy's `search_is_some` with the next-solver)

@bjorn3

Rollup merge of #163531 - paradoxicalguy:infer-indices-clean, r=petrochenkov rustc_ast_lowering: track implicit Self via explicit flag instead of name fixes #163457 & added a ui regression test for the reported reproducer. r? @bjorn3

rustbot assigned bjorn3 Sep 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 30, 2026

rustbot assigned Enselic and unassigned bjorn3 Oct 2, 2026

aerooneqq reviewed Oct 2, 2026

View reviewed changes

Comment thread compiler/rustc_ast_lowering/src/delegation/generics.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2026

paradoxicalguy force-pushed the infer-indices-clean branch from 9880f7a to 5a3d0cc Compare October 2, 2026 21:33

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 3, 2026

rustbot assigned petrochenkov and unassigned Enselic Oct 3, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2026

paradoxicalguy changed the title ~~rustc_ast_lowering: skip Self and synthetic params in infer_indices~~ rustc_ast_lowering: track implicit Self via explicit flag instead of name Oct 5, 2026

rustc_ast_lowering: track implicit Self via explicit flag instead of …

f20f0c4

…name

paradoxicalguy force-pushed the infer-indices-clean branch from 5a3d0cc to f20f0c4 Compare October 5, 2026 10:08

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2026

oscarnava0830-ui mentioned this pull request Oct 5, 2026

Fix an edge for certain platforms that views trailing cur dir components as a separate missing directory components #162267

Open

JonathanBrouwer mentioned this pull request Oct 5, 2026

Rollup of 5 pull requests #163803

Closed

JonathanBrouwer mentioned this pull request Oct 5, 2026

Rollup of 12 pull requests #163827

Closed

JonathanBrouwer mentioned this pull request Oct 5, 2026

Rollup of 11 pull requests #163829

Merged

rust-bors Bot merged commit 14af779 into rust-lang:main Oct 5, 2026
14 of 15 checks passed

rustbot added this to the 1.101.0 milestone Oct 5, 2026

Uh oh!

Conversation

paradoxicalguy commented Sep 30, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paradoxicalguy commented Sep 30, 2026

Uh oh!

paradoxicalguy commented Oct 1, 2026

Uh oh!

paradoxicalguy commented Oct 1, 2026

Uh oh!

bjorn3 commented Oct 2, 2026

Uh oh!

petrochenkov commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Oct 2, 2026

Uh oh!

petrochenkov commented Oct 2, 2026

Uh oh!

rust-bors Bot commented Oct 2, 2026

Uh oh!

Uh oh!

rustbot commented Oct 2, 2026

Uh oh!

paradoxicalguy commented Oct 3, 2026

Uh oh!

Enselic commented Oct 3, 2026

Uh oh!

rustbot commented Oct 3, 2026

Uh oh!

Enselic commented Oct 3, 2026

Uh oh!

paradoxicalguy commented Oct 3, 2026

Uh oh!

aerooneqq commented Oct 5, 2026

Uh oh!

aerooneqq commented Oct 5, 2026

Uh oh!

rust-bors Bot commented Oct 5, 2026

Uh oh!

paradoxicalguy commented Oct 5, 2026

Uh oh!

rust-bors Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Oct 5, 2026

Uh oh!

rust-bors Bot commented Oct 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

paradoxicalguy commented Sep 30, 2026 •

edited by rustbot

Loading

petrochenkov commented Oct 2, 2026 •

edited

Loading

rust-bors Bot commented Oct 5, 2026 •

edited

Loading