Rollup of 12 pull requests - #163827
Rollup of 12 pull requests#163827JonathanBrouwer wants to merge 40 commits into
Conversation
…, r=petrochenkov rustc_ast_lowering: track implicit Self via explicit flag instead of name fixes rust-lang#163457 & added a ui regression test for the reported reproducer. r? @bjorn3
[rustdoc] Fix how `Deref` items is handled. Fixes rust-lang#160236. This PR fixes a few things around how we handle `Deref`: * Since nothing except for methods is callable through a `Deref`, only methods should be kept * If the `Deref::Target` is a type implementing `Copy`, then methods taking `self` work and should be displayed. <del>During the `clean` pass, I store the item `DefId` on which `Deref` is implemented in a `DefIdSet` if the `Deref::Target` implements `Copy`. Then during rendering, we check if the "parent item" is in in the `DefIdSet`, and if so, we keep methods with `self`.</del> <del>Now you might wonder why the item and not the derefed item. It's because the `DefId` we get from the computed type doesn't match the `DefId` of the actual type (that's where I spent most of my time, finding an ID (`DefId`/`ItemId`) I can use as key T_T).</del> It computes in `html/render` if the `Deref::Target` item is copy before rendering it. So to resume: * `&self` is always kept. * `&mut self` is kept if `DerefMut` is implemented (nothing changed there). * `self` is kept only if `Deref::Target` is `Copy`. * Everything else disappears as they're not callable through `Deref`. r? @camelid
Rollup of 12 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
|
⌛ Trying commit f2010fb with merge fbe3787… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/37347377614 |
|
⌛ Testing commit f2010fb with merge a93d401... Workflow: https://github.com/rust-lang/rust/actions/runs/37347410137 |
…uwer Rollup of 12 pull requests Successful merges: - #163531 (rustc_ast_lowering: track implicit Self via explicit flag instead of name) - #160915 ([rustdoc] Fix how `Deref` items is handled.) - #163364 (make semicolon_in_expressions_from_non_local_macros not report-in-deps) - #163770 (document the rustc_comptime attribute) - #163780 (Skip optional asserts in SsaRangePropagation) - #163785 (Bump Windows CI LLVM to 22.1.8) - #163796 (continue crashes tests `-Znext-solver` work) - #163646 (Get `inputs_hir` directly from `decl`) - #163733 (Fix extra spaces in integer format_into docs) - #163773 (Update GitHub Actions to v26) - #163787 (moves rustc_legacy_const_generics checks into attribute parsing) - #163810 (Fix an issue for clippy's `search_is_some` with the next-solver)
|
PR #160915, which is a member of this rollup, was unapproved. This rollup was thus unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Successful merges:
Derefitems is handled. #160915 ([rustdoc] Fix howDerefitems is handled.)-Znext-solverwork #163796 (continue crashes tests-Znext-solverwork)inputs_hirdirectly fromdecl#163646 (Getinputs_hirdirectly fromdecl)search_is_somewith the next-solver #163810 (Fix an issue for clippy'ssearch_is_somewith the next-solver)r? @ghost
Create a similar rollup