Skip to content

Comments

[https://nvbugs/5769890][fix] enable system memory to transfer active message in NIXL ucx#10602

Merged
chuangz0 merged 3 commits intoNVIDIA:mainfrom
chuangz0:fix_nixl_am
Jan 19, 2026
Merged

[https://nvbugs/5769890][fix] enable system memory to transfer active message in NIXL ucx#10602
chuangz0 merged 3 commits intoNVIDIA:mainfrom
chuangz0:fix_nixl_am

Conversation

@chuangz0
Copy link
Collaborator

@chuangz0 chuangz0 commented Jan 12, 2026

Summary by CodeRabbit

  • Tests
    • Enhanced test environment configurations for disaggregated model testing scenarios.
    • Updated test skip list to reflect current test status across multiple test modules.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

The changes add the UCX_MM_ERROR_HANDLING environment variable configured to "y" across multiple disaggregated test runner functions, and update the test waive-list by removing three disaggregated benchmark test waivers while adding three new test waivers.

Changes

Cohort / File(s) Summary
Environment Configuration
tests/integration/defs/disaggregated/test_disaggregated.py
Added UCX_MM_ERROR_HANDLING = "y" to run_env in run_disaggregated_test, run_disaggregated_benchmark, and run_disaggregated_aiperf; also added to env in test_disaggregated_deepseek_v3_lite_fp8_nixl path
Test Waive List
tests/integration/test_lists/waives.txt
Removed three SKIP waivers for disaggregated benchmark tests (llama-3.1-8b-instruct-hf-fp8, DeepSeek-V3-Lite-bf16, llama-v3-8b-hf); added three new SKIP waivers for triton_server, flashinfer_star_attn, and ray_orchestrator tests

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. The template sections for 'Description' and 'Test Coverage' are empty with only the placeholder comments present. No substantive content explains what was changed, why it was necessary, or what tests validate the changes. Fill in the 'Description' section explaining the issue and solution, and the 'Test Coverage' section listing relevant tests that validate the changes in the PR.
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly follows the required format with NVBugs ID and [fix] type, accurately describing the main change of enabling system memory for active message transfer in NIXL UCX.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/integration/defs/disaggregated/test_disaggregated.py (1)

1-1: Update the copyright year to include 2026.

The copyright header shows "2022-2024" but the file has been meaningfully modified in 2026. As per coding guidelines, the copyright header should reflect the year of the latest meaningful modification.

Suggested fix
-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
🧹 Nitpick comments (1)
tests/integration/defs/disaggregated/test_disaggregated.py (1)

1186-1194: Consider removing redundant UCX_MM_ERROR_HANDLING setting.

This line is redundant since run_disaggregated_test (line 365) now sets UCX_MM_ERROR_HANDLING=y unconditionally in run_env. The value set here will be overwritten by the runner.

If the intent is to document that this test specifically requires this setting, a comment would be clearer. Otherwise, consider removing this line for consistency with other tests that rely on the runner's defaults.

Option: Remove redundant setting
     env = llm_venv._new_env.copy()
     env["TRTLLM_USE_NIXL_KVCACHE"] = "1"
     env["UCX_TLS"] = "^ib"
-    env["UCX_MM_ERROR_HANDLING"] = "y"
     run_disaggregated_test(disaggregated_example_root,
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11da7e3 and f7175c3.

📒 Files selected for processing (2)
  • tests/integration/defs/disaggregated/test_disaggregated.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces. Do not use tabs
Always maintain the namespace when importing Python modules, even if only one class or function from a module is used
Python filenames should use snake_case (e.g., some_file.py)
Python classes should use PascalCase (e.g., class SomeClass)
Python functions and methods should use snake_case (e.g., def my_awesome_function():)
Python local variables should use snake_case, with prefix k for variable names that start with a number (e.g., k_99th_percentile)
Python global variables should use upper snake_case with prefix G (e.g., G_MY_GLOBAL)
Python constants should use upper snake_case (e.g., MY_CONSTANT)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Use comments in Python for code within a function, or interfaces that are local to a file
Use Google-style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with the format """<type>: Description"""
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of errors possible
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block for the main logic

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
**/*.{cpp,cc,cxx,h,hpp,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification

Files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
🧠 Learnings (4)
📓 Common learnings
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
Repo: NVIDIA/TensorRT-LLM PR: 6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.

Applied to files:

  • tests/integration/defs/disaggregated/test_disaggregated.py
🧬 Code graph analysis (1)
tests/integration/defs/disaggregated/test_disaggregated.py (2)
tests/unittest/llmapi/apps/_test_disagg_serving_multi_nodes.py (1)
  • env (66-74)
tests/unittest/llmapi/apps/_test_disagg_serving_multi_nodes_service_discovery.py (1)
  • env (48-56)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/defs/disaggregated/test_disaggregated.py (3)

1495-1497: LGTM!

Consistent addition of UCX_MM_ERROR_HANDLING alongside the existing UCX_TLS setting in the benchmark runner.


1676-1678: LGTM!

Consistent addition of UCX_MM_ERROR_HANDLING alongside the existing UCX_TLS setting in the aiperf runner.


363-365: Clarify whether UCX_MM_ERROR_HANDLING=y should apply globally or only to NIXL tests.

The global setting at line 365 applies this variable to all disaggregated tests regardless of backend (MPI, PyTorch, UCX, NIXL), but the code shows inconsistent patterns: the NIXL-specific test explicitly sets UCX_MM_ERROR_HANDLING=y before calling the runner (suggesting it's NIXL-specific), while the UCX test only sets UCX_TLS="^ib" and relies on the global setting. Additionally, no official UCX documentation exists for UCX_MM_ERROR_HANDLING (web search found no reference in OpenUCX docs), so verify this variable is correct and intentionally global rather than NIXL-conditional.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31552 [ run ] triggered by Bot. Commit: f7175c3

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31552 [ run ] completed with state SUCCESS. Commit: f7175c3
/LLM/main/L0_MergeRequest_PR pipeline #24395 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31668 [ run ] triggered by Bot. Commit: c86398c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31668 [ run ] completed with state SUCCESS. Commit: c86398c
/LLM/main/L0_MergeRequest_PR pipeline #24497 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32045 [ run ] triggered by Bot. Commit: 804b3af

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32045 [ run ] completed with state SUCCESS. Commit: 804b3af
/LLM/main/L0_MergeRequest_PR pipeline #24835 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@pcastonguay
Copy link
Collaborator

/bot run --add-multi-gpu-test --disable-fail-fast

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
@chuangz0
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

1 similar comment
@pcastonguay
Copy link
Collaborator

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32305 [ run ] triggered by Bot. Commit: f506909

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32305 [ run ] completed with state SUCCESS. Commit: f506909
/LLM/main/L0_MergeRequest_PR pipeline #25034 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@pcastonguay
Copy link
Collaborator

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32339 [ run ] triggered by Bot. Commit: f506909

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32339 [ run ] completed with state SUCCESS. Commit: f506909
/LLM/main/L0_MergeRequest_PR pipeline #25058 completed with status: 'SUCCESS'

@chuangz0 chuangz0 merged commit 4f04532 into NVIDIA:main Jan 19, 2026
5 checks passed
yuxianq added a commit to yuxianq/TensorRT-LLM that referenced this pull request Jan 23, 2026
… message in NIXL ucx (NVIDIA#10602)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
yuxianq added a commit to yuxianq/TensorRT-LLM that referenced this pull request Jan 26, 2026
… message in NIXL ucx (NVIDIA#10602)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
yuxianq added a commit that referenced this pull request Jan 26, 2026
… message in NIXL ucx (cherry-pick from #10602) (#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
zheyuf pushed a commit to zheyuf/TensorRT-LLM that referenced this pull request Jan 29, 2026
… message in NIXL ucx (NVIDIA#10602)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 6, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 7, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 8, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants