Skip to content

Comments

[https://nvbugs/5769890][fix] enable system memory to transfer active message in NIXL ucx (cherry-pick from https://github.com/NVIDIA/TensorRT-LLM/pull/10602)#10914

Merged
yuxianq merged 1 commit intoNVIDIA:release/1.2from
yuxianq:fix_nixl_am-release-1.2
Jan 26, 2026
Merged

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented Jan 22, 2026

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage for disaggregated serving with improved error handling
    • Backend-aware test configurations for deployment scenarios
    • Reactivated previously skipped integration tests for expanded coverage

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yuxianq yuxianq requested review from chuangz0 and litaotju January 22, 2026 06:51
@yuxianq yuxianq requested a review from a team as a code owner January 22, 2026 06:51
@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 22, 2026

/bot run --disable-fail-fast --add-multi-gpu-test

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

The changes add UCX (Unified Collective Communication) environment variable configurations across disaggregated test files to enhance memory error handling and transport settings for backend-specific behavior and NVLink detection during test execution.

Changes

Cohort / File(s) Summary
Disaggregated test environment setup
tests/integration/defs/disaggregated/test_disaggregated.py, tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py, tests/integration/defs/accuracy/test_disaggregated_serving.py
Adds UCX_MM_ERROR_HANDLING="y" environment variable across multiple disaggregated test entry points and server configurations. In test_disaggregated_serving.py, introduces backend-aware logic (checking for NIXL backend) and conditional UCX_TLS settings for NVLink detection. In the other two files, adds the same memory error-handling setting to existing environment configurations for test runners and MPI pool executors.
Test skip list updates
tests/integration/test_lists/waives.txt
Removes 3 lines containing test skip entries, reducing the number of tests marked as skipped in disaggregated test configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly empty - it contains only the template structure with uncommented sections (Description, Test Coverage) left blank and no actual explanation of the issue or test coverage details provided. Add detailed description of the issue being fixed and list the relevant tests (test_disaggregated.py, test_disaggregated_single_gpu.py, test_accuracy/test_disaggregated_serving.py) that validate these UCX environment variable changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title properly follows the template format [NVBugs ID][type] with a clear, specific summary of the change - enabling system memory for active message transfer in NIXL UCX, and notes it's a cherry-pick from upstream PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33109 [ run ] triggered by Bot. Commit: 125f7d2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33109 [ run ] completed with state SUCCESS. Commit: 125f7d2
/LLM/release-1.2/L0_MergeRequest_PR pipeline #155 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 23, 2026

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33249 [ run ] triggered by Bot. Commit: 125f7d2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33249 [ run ] completed with state ABORTED. Commit: 125f7d2
LLM/release-1.2/L0_MergeRequest_PR #183 (Blue Ocean) completed with status: ABORTED

@yuxianq yuxianq force-pushed the fix_nixl_am-release-1.2 branch from 125f7d2 to ce7fcc9 Compare January 23, 2026 03:29
@ZhanruiSunCh
Copy link
Collaborator

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33292 [ run ] triggered by Bot. Commit: ce7fcc9

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33292 [ run ] completed with state SUCCESS. Commit: ce7fcc9
/LLM/release-1.2/L0_MergeRequest_PR pipeline #191 completed with status: 'ABORTED'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 23, 2026

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33382 [ run ] triggered by Bot. Commit: 67117cf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33382 [ run ] completed with state SUCCESS. Commit: 67117cf
/LLM/release-1.2/L0_MergeRequest_PR pipeline #207 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 24, 2026

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33425 [ run ] triggered by Bot. Commit: 67117cf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33425 [ run ] completed with state ABORTED. Commit: 67117cf
LLM/release-1.2/L0_MergeRequest_PR #215 (Blue Ocean) completed with status: ABORTED

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 24, 2026

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33437 [ run ] triggered by Bot. Commit: 67117cf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33437 [ run ] completed with state SUCCESS. Commit: 67117cf
/LLM/release-1.2/L0_MergeRequest_PR pipeline #217 completed with status: 'SUCCESS'

… message in NIXL ucx (NVIDIA#10602)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
@yuxianq yuxianq force-pushed the fix_nixl_am-release-1.2 branch from 4074642 to aa4e537 Compare January 26, 2026 03:34
@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 26, 2026

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33520 [ reuse-pipeline ] triggered by Bot. Commit: aa4e537

@yuxianq yuxianq enabled auto-merge (squash) January 26, 2026 03:45
@tensorrt-cicd
Copy link
Collaborator

PR_Github #33520 [ reuse-pipeline ] completed with state SUCCESS. Commit: aa4e537
Reusing PR_Github #33437 for commit aa4e537

@yuxianq yuxianq merged commit 8f4b8f2 into NVIDIA:release/1.2 Jan 26, 2026
5 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 5, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 6, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 7, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 8, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Feb 9, 2026
… message in NIXL ucx (cherry-pick from NVIDIA#10602) (NVIDIA#10914)

Signed-off-by: Chuang Zhu <[email protected]>
Signed-off-by: Yuxian Qiu <[email protected]>
Signed-off-by: Wangshanshan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants