Skip to content

Comments

[None][chore] Remove closed bugs#10982

Merged
xinhe-nv merged 1 commit intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260125
Jan 27, 2026
Merged

[None][chore] Remove closed bugs#10982
xinhe-nv merged 1 commit intoNVIDIA:mainfrom
xinhe-nv:user/qa/unwaive_20260125

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jan 25, 2026

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Reduced waived test cases to enable stricter test enforcement across multiple testing categories.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20260125 branch from b7b91b3 to e6f1b1b Compare January 26, 2026 05:09
@xinhe-nv xinhe-nv marked this pull request as ready for review January 26, 2026 05:09
@xinhe-nv
Copy link
Collaborator Author

/bot run

@xinhe-nv xinhe-nv enabled auto-merge (squash) January 26, 2026 05:09
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

This PR removes 37 waived test entries from the test waiver list file, reducing the number of currently skipped tests across multiple test categories. No structural changes, new tests, or logic modifications are introduced.

Changes

Cohort / File(s) Summary
Test Waiver Updates
tests/integration/test_lists/waives.txt
Removed 37 SKIP entries from various test categories including CLI flow, LLaMA/GPT tests, disaggregated serving, multimodal, and Nemotron-related tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • LarryXFly
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but provides the core information. However, it lacks the structured sections (Description, Test Coverage, PR Checklist) specified in the template. Expand the description to include the standard sections: provide details about which bugs were removed and why, document relevant test coverage, and complete the PR checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Remove closed bugs' directly matches the PR's purpose of removing closed bugs from the waives.txt file, making it clear and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33525 [ run ] triggered by Bot. Commit: e6f1b1b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #33525 [ run ] completed with state SUCCESS. Commit: e6f1b1b
/LLM/main/L0_MergeRequest_PR pipeline #25861 completed with status: 'SUCCESS'

@xinhe-nv xinhe-nv merged commit 069ad30 into NVIDIA:main Jan 27, 2026
7 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20260125 branch January 27, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants