[Branch-2.1](Outfile) Fixed the problem that the concurrent Outfile wrote multiple Success files#33870
Merged
morningman merged 2 commits intoapache:branch-2.1from Apr 19, 2024
Merged
Conversation
…ltiple Success files (apache#33016) **Problem:** When we enable concurrent `Outfile` and specify the `success_file_name`, a SUCCESS file is written for each BE instance, which is not what we expected **solution:** Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| void PInternalServiceImpl::outfile_write_success(google::protobuf::RpcController* controller, |
Contributor
There was a problem hiding this comment.
warning: method 'outfile_write_success' can be made static [readability-convert-member-functions-to-static]
Suggested change
| void PInternalServiceImpl::outfile_write_success(google::protobuf::RpcController* controller, | |
| static void PInternalServiceImpl::outfile_write_success(google::protobuf::RpcController* controller, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
backport: #33016
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...