[Fix](Outfile) Fixed the problem that the concurrent Outfile wrote multiple Success files#33016
Merged
morningman merged 5 commits intoapache:masterfrom Apr 9, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| void PInternalService::outfile_write_success(google::protobuf::RpcController* controller, |
Contributor
There was a problem hiding this comment.
warning: method 'outfile_write_success' can be made static [readability-convert-member-functions-to-static]
Suggested change
| void PInternalService::outfile_write_success(google::protobuf::RpcController* controller, | |
| static void PInternalService::outfile_write_success(google::protobuf::RpcController* controller, |
TPC-H: Total hot run time: 38198 ms |
TPC-DS: Total hot run time: 182437 ms |
ClickBench: Total hot run time: 30.04 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
morningman
reviewed
Mar 31, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38972 ms |
TPC-DS: Total hot run time: 182186 ms |
ClickBench: Total hot run time: 31.25 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38918 ms |
TPC-DS: Total hot run time: 183296 ms |
ClickBench: Total hot run time: 30.58 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
Contributor
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Apr 8, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 10, 2024
…ltiple Success files (apache#33016) **Problem:** When we enable concurrent `Outfile` and specify the `success_file_name`, a SUCCESS file is written for each BE instance, which is not what we expected **solution:** Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
BePPPower
added a commit
to BePPPower/doris
that referenced
this pull request
Apr 16, 2024
…ltiple Success files (apache#33016) **Problem:** When we enable concurrent `Outfile` and specify the `success_file_name`, a SUCCESS file is written for each BE instance, which is not what we expected **solution:** Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
BePPPower
added a commit
to BePPPower/doris
that referenced
this pull request
Apr 19, 2024
…ltiple Success files (apache#33016) **Problem:** When we enable concurrent `Outfile` and specify the `success_file_name`, a SUCCESS file is written for each BE instance, which is not what we expected **solution:** Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
BePPPower
added a commit
to BePPPower/doris
that referenced
this pull request
Apr 19, 2024
…ltiple Success files (apache#33016) **Problem:** When we enable concurrent `Outfile` and specify the `success_file_name`, a SUCCESS file is written for each BE instance, which is not what we expected **solution:** Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
morningman
added
dev/2.1.3-merged
kind/fix
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…ltiple Success files apache#33016 (apache#33720)
16 tasks
morningman
added a commit
that referenced
this pull request
Oct 22, 2025
) ### What problem does this PR solve? Related PR: #33016 Introduced from #33016, when specify the "schema" property in outfile clause with parquet format, it will return error: ``` Parquet schema number does not equal to select item number ``` This is because we wrongly analyze `OutfileClause` twice.
dwdwqfwe
pushed a commit
to dwdwqfwe/doris
that referenced
this pull request
Oct 24, 2025
…che#57232) ### What problem does this PR solve? Related PR: apache#33016 Introduced from apache#33016, when specify the "schema" property in outfile clause with parquet format, it will return error: ``` Parquet schema number does not equal to select item number ``` This is because we wrongly analyze `OutfileClause` twice.
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
) ### What problem does this PR solve? Related PR: #33016 Introduced from #33016, when specify the "schema" property in outfile clause with parquet format, it will return error: ``` Parquet schema number does not equal to select item number ``` This is because we wrongly analyze `OutfileClause` twice.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Oct 30, 2025
…che#57232) Related PR: apache#33016 Introduced from apache#33016, when specify the "schema" property in outfile clause with parquet format, it will return error: ``` Parquet schema number does not equal to select item number ``` This is because we wrongly analyze `OutfileClause` twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem:
When we enable concurrent
Outfileand specify thesuccess_file_name, a SUCCESS file is written for each BE instance, which is not what we expectedsolution:
Therefore, we added a new RPC request that when the Outfile was completed, the FE sent an RPC to the Be request to write one Success file.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...