Skip to content

Comments

[followup](memory) Block should be moved by hash shuffling#41740

Merged
Gabriel39 merged 2 commits intoapache:masterfrom
Gabriel39:minor_1012
Oct 12, 2024
Merged

[followup](memory) Block should be moved by hash shuffling#41740
Gabriel39 merged 2 commits intoapache:masterfrom
Gabriel39:minor_1012

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Oct 12, 2024

Proposed changes

Follow-up for #41676

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Oct 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 12, 2024

TeamCity be ut coverage result:
Function Coverage: 37.39% (9658/25828)
Line Coverage: 28.66% (80141/279589)
Region Coverage: 28.09% (41439/147515)
Branch Coverage: 24.70% (21107/85462)
Coverage Report: http://coverage.selectdb-in.cc/coverage/635dbbfd680575b5338d14e3c1781308ddf58051_635dbbfd680575b5338d14e3c1781308ddf58051/report/index.html

BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 12, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee previously approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39 Gabriel39 dismissed stale reviews from HappenLee and BiteTheDDDDt via b350feb October 12, 2024 04:19
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Oct 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2024
@doris-robot
Copy link

doris-robot commented Oct 12, 2024

TeamCity be ut coverage result:
Function Coverage: 37.39% (9664/25845)
Line Coverage: 28.64% (80150/279815)
Region Coverage: 28.08% (41433/147568)
Branch Coverage: 24.69% (21101/85454)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b350febd3ae8a375fcb02b224454c0cb78731824_b350febd3ae8a375fcb02b224454c0cb78731824/report/index.html

@Gabriel39 Gabriel39 merged commit cce5425 into apache:master Oct 12, 2024
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
4be7ee5 
)

Follow-up for apache#41676
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
58c9653 
)

Follow-up for apache#41676
dataroaring pushed a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[pick](branch-3.0) pick #39982 #40576 #41555 #41592 #41676 #41740 (#4…
54b4fa3 
…1808)
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 15, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
e90a846 
)

Follow-up for apache#41676
@Gabriel39 Gabriel39 mentioned this pull request Oct 15, 2024
Merged
Gabriel39 added a commit that referenced this pull request Oct 15, 2024
@Gabriel39
[pick](branch-2.1) pick #41676 #41740 #41857 (#41904)
b185dfc 
pick #41676 #41740 #41857
qzsee pushed a commit to qzsee/incubator-doris that referenced this pull request Oct 16, 2024
@Gabriel39
[followup](memory) Block should be moved by hash shuffling (apache#41740
272a8ae 
)

Follow-up for apache#41676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee left review comments

+1 more reviewer

@Mryange Mryange Mryange approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gabriel39 @doris-robot @BiteTheDDDDt @HappenLee @Mryange