[feature](function)support bit_test function#42099
Merged
HappenLee merged 2 commits intoapache:masterfrom Oct 22, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| block.get_by_position(arguments[0]).column.get()) || | ||
| is_column_const(*block.get_by_position(arguments[0]).column)) { | ||
| execute_inner<T>(block, arguments, result, input_rows_count); | ||
| return true; |
Contributor
There was a problem hiding this comment.
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/vec/functions/function_bit_test.cpp:53:
- if (auto col = check_and_get_column<ColumnVector<T>>(
- block.get_by_position(arguments[0]).column.get()) ||
- is_column_const(*block.get_by_position(arguments[0]).column)) {
- execute_inner<T>(block, arguments, result, input_rows_count);
- return true;
- }
- return false;
+ return auto col = check_and_get_column<ColumnVector<T>>(
+ block.get_by_position(arguments[0]).column.get()) ||
+ is_column_const(*block.get_by_position(arguments[0]).column);
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41475 ms |
TPC-DS: Total hot run time: 193048 ms |
ClickBench: Total hot run time: 33.55 s |
HappenLee
reviewed
Oct 18, 2024
| for (int i = 0; i < input_rows_count; ++i) { | ||
| auto first_value = first_column_data[index_check_const(i, is_consts[0])]; | ||
| auto second_value = second_column_data[index_check_const(i, is_consts[1])]; | ||
| res_data[i] = ((first_value >> second_value) & 1); |
Contributor
There was a problem hiding this comment.
if second_value is nagtive, It's a UB in CPP.
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41363 ms |
TPC-DS: Total hot run time: 192227 ms |
ClickBench: Total hot run time: 33.08 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Oct 22, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41132 ms |
TPC-DS: Total hot run time: 191726 ms |
ClickBench: Total hot run time: 32.45 s |
|
TeamCity be ut coverage result: |
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 30, 2024
support bit_test function doc: apache/doris-website#1214
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
support bit_test function
doc: apache/doris-website#1214