[opt](filecache) Let base compaction output rowsets write filecache when cache size is enough#53801
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Add a config for this feature, we can remove it in the future.
TPC-H: Total hot run time: 34369 ms |
TPC-DS: Total hot run time: 188081 ms |
ClickBench: Total hot run time: 32.01 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
f78aa82 to
a91aacd
Compare
a91aacd to
8737d54
Compare
we already have a config for force write filecache, how do you think ? @gavinchou |
be/src/io/fs/file_writer.h
Outdated
| bool sync_file_data = true; // Whether flush data into storage system | ||
| uint64_t file_cache_expiration = 0; // Absolute time | ||
| bool sync_file_data = true; // Whether flush data into storage system | ||
| uint64_t file_cache_expiration = 0; // Absolute time |
There was a problem hiding this comment.
naming file_cache_expired_at_s
There was a problem hiding this comment.
naming
file_cache_expired_at_s
没改过这个字段,只是增加了注释缩进,因为clang-format报错的原因
|
run buildall |
TPC-H: Total hot run time: 34009 ms |
TPC-DS: Total hot run time: 187211 ms |
ClickBench: Total hot run time: 32.09 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
8737d54 to
2d40e65
Compare
|
run buildall |
|
add a config |
TPC-H: Total hot run time: 34501 ms |
TPC-DS: Total hot run time: 188064 ms |
ClickBench: Total hot run time: 32.79 s |
TPC-H: Total hot run time: 34131 ms |
TPC-DS: Total hot run time: 185281 ms |
ClickBench: Total hot run time: 32.33 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…hen cache size is enough (apache#53801)
…hen cache size is enough (apache#53801)

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)