Skip to content

Comments

branch-3.1: [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough #53801#54692

Merged
morrySnow merged 1 commit intoapache:branch-3.1from
swjtu-zhanglei:branch-3.1-pick
Aug 14, 2025
Merged

branch-3.1: [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough #53801#54692
morrySnow merged 1 commit intoapache:branch-3.1from
swjtu-zhanglei:branch-3.1-pick

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented Aug 13, 2025

picked from #53801

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@swjtu-zhanglei swjtu-zhanglei changed the title [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough (#53801) branch-3.1: [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough (#53801) Aug 13, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 33124 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 82de25c609121f82f56f8e6ea5a7df662ae4be66, data reload: false

------ Round 1 ----------------------------------
q1	17626	5492	5452	5452
q2	2040	400	273	273
q3	12242	1249	773	773
q4	10226	904	468	468
q5	8193	2442	2197	2197
q6	196	167	138	138
q7	920	745	630	630
q8	9330	1481	1195	1195
q9	5366	4975	4966	4966
q10	6786	2299	1877	1877
q11	474	287	264	264
q12	338	368	218	218
q13	17756	3614	3035	3035
q14	229	228	210	210
q15	535	472	480	472
q16	437	426	371	371
q17	605	896	371	371
q18	7066	6398	6561	6398
q19	1527	969	576	576
q20	333	347	210	210
q21	2893	2259	2026	2026
q22	1070	1046	1004	1004
Total cold run time: 106188 ms
Total hot run time: 33124 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5559	5537	5544	5537
q2	243	323	236	236
q3	2254	2655	2329	2329
q4	1395	1840	1375	1375
q5	4452	5061	4975	4975
q6	172	165	135	135
q7	2064	1984	1797	1797
q8	2710	2901	2770	2770
q9	7289	7300	7202	7202
q10	3041	3310	2721	2721
q11	585	517	489	489
q12	659	777	594	594
q13	3433	3773	3186	3186
q14	285	308	283	283
q15	532	473	459	459
q16	437	510	436	436
q17	1238	1758	1304	1304
q18	7715	7487	7382	7382
q19	863	1046	1214	1046
q20	2020	2082	1950	1950
q21	5417	4943	4659	4659
q22	1098	1097	1014	1014
Total cold run time: 53461 ms
Total hot run time: 51879 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192704 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 82de25c609121f82f56f8e6ea5a7df662ae4be66, data reload: false

query1	973	383	384	383
query2	6262	1960	1856	1856
query3	8693	208	205	205
query4	33571	24224	23465	23465
query5	3757	605	453	453
query6	292	199	187	187
query7	4204	489	309	309
query8	305	237	232	232
query9	9506	2551	2547	2547
query10	486	321	258	258
query11	18131	15507	15121	15121
query12	162	111	105	105
query13	1556	535	421	421
query14	9177	6674	6652	6652
query15	206	198	178	178
query16	7920	692	552	552
query17	1590	761	609	609
query18	2099	435	333	333
query19	213	185	165	165
query20	125	121	122	121
query21	210	132	112	112
query22	4742	4905	4684	4684
query23	35083	34709	34434	34434
query24	7721	2747	2732	2732
query25	567	501	425	425
query26	1067	289	173	173
query27	2516	473	361	361
query28	5712	2213	2180	2180
query29	816	603	468	468
query30	236	194	164	164
query31	1016	912	854	854
query32	95	64	65	64
query33	497	366	324	324
query34	780	907	519	519
query35	792	798	742	742
query36	1013	1063	959	959
query37	113	97	67	67
query38	3973	4042	4108	4042
query39	1552	1504	1468	1468
query40	209	119	112	112
query41	53	53	47	47
query42	125	107	117	107
query43	522	530	482	482
query44	1418	828	828	828
query45	184	174	180	174
query46	892	1048	685	685
query47	1984	2006	1953	1953
query48	415	452	354	354
query49	763	519	395	395
query50	683	686	426	426
query51	7406	7326	7232	7232
query52	106	107	94	94
query53	235	261	202	202
query54	550	556	478	478
query55	80	82	80	80
query56	270	279	283	279
query57	1276	1295	1218	1218
query58	244	220	220	220
query59	3051	3200	3020	3020
query60	299	274	263	263
query61	116	111	118	111
query62	817	753	705	705
query63	236	196	197	196
query64	4502	1001	640	640
query65	3380	3295	3291	3291
query66	990	402	317	317
query67	16347	15785	15624	15624
query68	8062	853	539	539
query69	480	302	269	269
query70	1195	1088	1138	1088
query71	433	297	263	263
query72	5144	3735	3859	3735
query73	660	750	358	358
query74	10010	9181	9240	9181
query75	3880	3144	2658	2658
query76	3533	1163	771	771
query77	754	371	288	288
query78	10442	10458	9568	9568
query79	2578	893	614	614
query80	630	528	441	441
query81	509	257	220	220
query82	587	122	88	88
query83	163	158	143	143
query84	239	104	79	79
query85	770	377	298	298
query86	344	300	277	277
query87	4319	4338	4237	4237
query88	4509	2399	2379	2379
query89	401	335	296	296
query90	1801	194	192	192
query91	140	137	118	118
query92	65	69	55	55
query93	1194	872	550	550
query94	636	389	320	320
query95	348	281	265	265
query96	487	598	285	285
query97	3200	3318	3164	3164
query98	234	208	197	197
query99	1716	1429	1311	1311
Total cold run time: 294345 ms
Total hot run time: 192704 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 82de25c609121f82f56f8e6ea5a7df662ae4be66, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.02
query3	0.23	0.07	0.07
query4	1.64	0.11	0.10
query5	0.52	0.52	0.51
query6	1.12	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.51
query10	0.56	0.54	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.12
query13	0.64	0.59	0.58
query14	0.78	0.79	0.79
query15	0.86	0.82	0.82
query16	0.38	0.41	0.40
query17	1.07	1.08	1.03
query18	0.24	0.21	0.23
query19	1.88	1.75	1.82
query20	0.01	0.02	0.01
query21	15.39	0.94	0.56
query22	0.75	0.78	0.67
query23	15.13	1.48	0.52
query24	3.57	0.91	1.61
query25	0.14	0.08	0.27
query26	0.37	0.16	0.15
query27	0.05	0.05	0.04
query28	13.24	0.99	0.44
query29	12.62	3.83	3.25
query30	0.24	0.11	0.07
query31	2.81	0.62	0.39
query32	3.22	0.53	0.45
query33	2.97	3.02	3.01
query34	16.81	5.20	4.52
query35	4.54	4.55	4.58
query36	0.66	0.49	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.95 s
Total hot run time: 28.75 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 43.33% (13/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.46% (12671/27873)
Line Coverage 36.32% (113088/311325)
Region Coverage 35.36% (58450/165309)
Branch Coverage 32.58% (31831/97692)

@swjtu-zhanglei
Copy link
Contributor Author

run p0

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (30/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.20% (20986/27540)
Line Coverage 69.55% (216416/311160)
Region Coverage 67.60% (129572/191686)
Branch Coverage 61.14% (67406/110246)

@morrySnow morrySnow changed the title branch-3.1: [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough (#53801) branch-3.1: [opt](filecache) Let base compaction output rowsets write filecache when cache size is enough #53801 Aug 14, 2025
@morrySnow morrySnow merged commit 002fd51 into apache:branch-3.1 Aug 14, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants