branch-3.0 cherry-pick [fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column#53897
Merged
dataroaring merged 8 commits intoapache:branch-3.0from Aug 12, 2025
Conversation
… and scalar column in variant sub-column (apache#53083) this pr main fix the problem which if we create table with ```variant_enable_flatten_nested``` then insert variant data: ```'{"nested":{"a":"1"}}``` and ```'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'``` we will meet core for reading so we should forbid this table property and for old data we insert different structure data will meet some error like this: ``` mysql> insert into vs values (2, '{"nested":{"a":"1"}}'); Query OK, 1 row affected (0.22 sec) {'label':'label_165a8209698c4391_988c6532615017c4', 'status':'VISIBLE', 'txnId':'1011'} mysql> insert into vs values (1, '{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]tablet 1752145213719 failed on majority backends: [DATA_QUALITY_ERROR]PStatus: (10.16.10.6)[DATA_QUALITY_ERROR]Ambiguous paths: v.nested.a vs v.nested.a with different nested part true vs false ```
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
added 2 commits
July 29, 2025 15:58
…apache#53923) fix batch insert into with structure-conflicts strings Before this we were able to successfully insert, but will meet query error like this: ``` mysql> insert into var_nested_load_conflict values (3, '{"nested": [{"a": 2.5, "b": "123.1"}]}'), (4, '{"nested": {"a": 2.5, "b": "123.1"}}'); Query OK, 2 rows affected (0.16 sec) {'label':'label_9279242ae3fd40e2_aabe077db2d37bb9', 'status':'VISIBLE', 'txnId':'16028'} mysql> desc var_nested_load_conflict; +------------+---------------+------+-------+---------+-------+ | Field | Type | Null | Key | Default | Extra | +------------+---------------+------+-------+---------+-------+ | k | bigint | Yes | true | NULL | | | v | variant | Yes | false | NULL | NONE | | v.nested.a | json | Yes | false | NULL | NONE | | v.nested.b | json | Yes | false | NULL | NONE | | v.nested.c | array<double> | Yes | false | NULL | NONE | +------------+---------------+------+-------+---------+-------+ 5 rows in set (0.10 sec) mysql> select * from var_nested_load_conflict; ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]Meet none array column when flatten nested array, path nested.b, type Nullable(JSONB) ``` So we don't allow this kind of insertion ``` mysql> insert into var_nested_load_conflict values (3, '{"nested": [{"a": 2.5, "b": "123.1"}]}'), (4, '{"nested": {"a": 2.5, "b": "123.1"}}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[DATA_QUALITY_ERROR][E46] Ambiguous paths: nested.b vs nested.b with different nested part false vs true ```
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 39587 ms |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 197409 ms |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 39985 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run external |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
added 2 commits
July 30, 2025 15:10
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
eldenmoon
changed the title
eldenmoon
reviewed
Aug 12, 2025
|
|
||
| // disable variant flatten nested as session variable, default is true, | ||
| // which means disable variant flatten nested when create table | ||
| public static final String DISABLE_VARIANT_FLATTEN_NESTED = "disable_variant_flatten_nested"; |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
backport: #53083
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)