[fix](variant) fix the reading core caused by inserting nested column and scalar column in variant sub-column#53083
Merged
eldenmoon merged 23 commits intoapache:masterfrom Jul 24, 2025
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
eldenmoon
reviewed
Jul 11, 2025
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Show resolved
Hide resolved
eldenmoon
reviewed
Jul 11, 2025
eldenmoon
reviewed
Jul 11, 2025
eldenmoon
reviewed
Jul 14, 2025
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
Outdated
Show resolved
Hide resolved
eldenmoon
reviewed
Jul 14, 2025
eldenmoon
reviewed
Jul 14, 2025
eldenmoon
reviewed
Jul 14, 2025
Member
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33963 ms |
TPC-DS: Total hot run time: 187382 ms |
ClickBench: Total hot run time: 30.31 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33121 ms |
TPC-DS: Total hot run time: 186455 ms |
ClickBench: Total hot run time: 30.26 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run nonConcurrent |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Jul 25, 2025
… and scalar column in variant sub-column (apache#53083) this pr main fix the problem which if we create table with ```variant_enable_flatten_nested``` then insert variant data: ```'{"nested":{"a":"1"}}``` and ```'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'``` we will meet core for reading so we should forbid this table property and for old data we insert different structure data will meet some error like this: ``` mysql> insert into vs values (2, '{"nested":{"a":"1"}}'); Query OK, 1 row affected (0.22 sec) {'label':'label_165a8209698c4391_988c6532615017c4', 'status':'VISIBLE', 'txnId':'1011'} mysql> insert into vs values (1, '{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]tablet 1752145213719 failed on majority backends: [DATA_QUALITY_ERROR]PStatus: (10.16.10.6)[DATA_QUALITY_ERROR]Ambiguous paths: v.nested.a vs v.nested.a with different nested part true vs false ```
16 tasks
amorynan
pushed a commit
to amorynan/doris
that referenced
this pull request
Jul 28, 2025
… and scalar column in variant sub-column (apache#53083) this pr main fix the problem which if we create table with ```variant_enable_flatten_nested``` then insert variant data: ```'{"nested":{"a":"1"}}``` and ```'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'``` we will meet core for reading so we should forbid this table property and for old data we insert different structure data will meet some error like this: ``` mysql> insert into vs values (2, '{"nested":{"a":"1"}}'); Query OK, 1 row affected (0.22 sec) {'label':'label_165a8209698c4391_988c6532615017c4', 'status':'VISIBLE', 'txnId':'1011'} mysql> insert into vs values (1, '{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]tablet 1752145213719 failed on majority backends: [DATA_QUALITY_ERROR]PStatus: (10.16.10.6)[DATA_QUALITY_ERROR]Ambiguous paths: v.nested.a vs v.nested.a with different nested part true vs false ```
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Jul 30, 2025
… and scalar column in variant sub-column (apache#53083) this pr main fix the problem which if we create table with ```variant_enable_flatten_nested``` then insert variant data: ```'{"nested":{"a":"1"}}``` and ```'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'``` we will meet core for reading so we should forbid this table property and for old data we insert different structure data will meet some error like this: ``` mysql> insert into vs values (2, '{"nested":{"a":"1"}}'); Query OK, 1 row affected (0.22 sec) {'label':'label_165a8209698c4391_988c6532615017c4', 'status':'VISIBLE', 'txnId':'1011'} mysql> insert into vs values (1, '{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]tablet 1752145213719 failed on majority backends: [DATA_QUALITY_ERROR]PStatus: (10.16.10.6)[DATA_QUALITY_ERROR]Ambiguous paths: v.nested.a vs v.nested.a with different nested part true vs false ```
zhiqiang-hhhh
pushed a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Aug 4, 2025
… and scalar column in variant sub-column (apache#53083) this pr main fix the problem which if we create table with ```variant_enable_flatten_nested``` then insert variant data: ```'{"nested":{"a":"1"}}``` and ```'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'``` we will meet core for reading so we should forbid this table property and for old data we insert different structure data will meet some error like this: ``` mysql> insert into vs values (2, '{"nested":{"a":"1"}}'); Query OK, 1 row affected (0.22 sec) {'label':'label_165a8209698c4391_988c6532615017c4', 'status':'VISIBLE', 'txnId':'1011'} mysql> insert into vs values (1, '{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.6)[INTERNAL_ERROR]tablet 1752145213719 failed on majority backends: [DATA_QUALITY_ERROR]PStatus: (10.16.10.6)[DATA_QUALITY_ERROR]Ambiguous paths: v.nested.a vs v.nested.a with different nested part true vs false ```
dataroaring
pushed a commit
that referenced
this pull request
Aug 12, 2025
…inserting nested column and scalar column in variant sub-column (#53897) ### What problem does this PR solve? backport: #53083 Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
this pr main fix the problem which if we create table with
variant_enable_flatten_nestedthen insert variant data:
'{"nested":{"a":"1"}}and'{"nested":[{"a":1,"c":1.1},{"b":"1"}]}'we will meet core for reading
so we should forbid this table property
and for old data we insert different structure data will meet some error like this:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)