Skip to content

[feat](cloud) change the type to optional in the alter storage vault command#54394

Merged
dataroaring merged 1 commit intoapache:masterfrom
felixwluo:feat-0806
Aug 8, 2025
Merged

[feat](cloud) change the type to optional in the alter storage vault command#54394
dataroaring merged 1 commit intoapache:masterfrom
felixwluo:feat-0806

Conversation

@felixwluo
Copy link
Contributor

@felixwluo felixwluo commented Aug 6, 2025

What problem does this PR solve?

change the type to optional in the alter storage vault command
before

ALTER STORAGE VAULT vault_name
PROPERTIES (
  "type"="S3",
  "s3.access_key" = "new_ak"
);

now

ALTER STORAGE VAULT vault_name
PROPERTIES (
  "s3.access_key" = "new_ak"
);

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@felixwluo felixwluo requested a review from dataroaring August 6, 2025 07:45
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@felixwluo
Copy link
Contributor Author

felixwluo commented Aug 6, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-H: Total hot run time: 33967 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df75760fddf06ab74c1933ef08a6a60c91938b72, data reload: false

------ Round 1 ----------------------------------
q1	17605	5311	5187	5187
q2	1960	312	186	186
q3	10257	1368	712	712
q4	10229	1035	542	542
q5	7529	2401	2223	2223
q6	178	166	135	135
q7	948	778	618	618
q8	9327	1310	1073	1073
q9	6727	5119	5046	5046
q10	6897	2368	1978	1978
q11	474	285	266	266
q12	364	363	233	233
q13	17777	3530	3003	3003
q14	235	240	239	239
q15	551	468	470	468
q16	418	427	378	378
q17	569	823	357	357
q18	7236	7154	7144	7144
q19	2780	974	572	572
q20	321	310	212	212
q21	3389	3052	2393	2393
q22	1065	1008	1002	1002
Total cold run time: 106836 ms
Total hot run time: 33967 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5461	5311	5303	5303
q2	244	306	214	214
q3	2089	2517	2197	2197
q4	1285	1679	1347	1347
q5	4151	4451	4419	4419
q6	223	176	135	135
q7	1885	2116	2050	2050
q8	2546	2512	2439	2439
q9	7240	7423	7520	7423
q10	3266	3404	3070	3070
q11	551	527	507	507
q12	798	815	639	639
q13	3631	3808	3224	3224
q14	312	324	287	287
q15	499	436	446	436
q16	528	670	523	523
q17	1266	1516	1581	1516
q18	7672	7777	7789	7777
q19	11393	905	896	896
q20	3177	1993	1795	1795
q21	14152	4299	4272	4272
q22	1083	1000	997	997
Total cold run time: 73452 ms
Total hot run time: 51466 ms

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-DS: Total hot run time: 170136 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit df75760fddf06ab74c1933ef08a6a60c91938b72, data reload: false

============================================
query1	981	371	449	371
query2	6532	1740	1728	1728
query3	6736	226	222	222
query4	26795	23093	22810	22810
query5	4397	634	521	521
query6	315	255	216	216
query7	4682	538	324	324
query8	290	242	232	232
query9	8644	2929	2931	2929
query10	477	352	294	294
query11	15510	15047	14762	14762
query12	189	147	133	133
query13	1662	559	414	414
query14	9562	5971	5997	5971
query15	216	190	174	174
query16	7130	689	511	511
query17	991	786	666	666
query18	2017	442	325	325
query19	246	213	188	188
query20	151	148	155	148
query21	213	132	112	112
query22	3839	3956	3858	3858
query23	34703	34106	34307	34106
query24	5323	2411	2426	2411
query25	474	525	473	473
query26	716	294	164	164
query27	1771	519	353	353
query28	2642	2314	2326	2314
query29	618	598	503	503
query30	292	251	197	197
query31	830	779	713	713
query32	91	79	76	76
query33	464	424	390	390
query34	791	849	524	524
query35	811	833	733	733
query36	1017	1067	922	922
query37	133	110	92	92
query38	3966	3998	3895	3895
query39	1439	1406	1382	1382
query40	243	145	130	130
query41	66	59	54	54
query42	143	124	124	124
query43	516	527	494	494
query44	1385	884	871	871
query45	200	184	186	184
query46	946	1075	678	678
query47	1789	1819	1729	1729
query48	419	431	326	326
query49	667	503	405	405
query50	713	694	418	418
query51	4233	4175	4180	4175
query52	131	137	122	122
query53	259	295	223	223
query54	646	663	549	549
query55	92	89	87	87
query56	350	360	349	349
query57	1188	1209	1151	1151
query58	330	322	335	322
query59	2655	2604	2480	2480
query60	401	404	406	404
query61	126	122	126	122
query62	780	742	645	645
query63	271	219	219	219
query64	2395	1112	786	786
query65	4261	4158	4118	4118
query66	1076	466	383	383
query67	query68	17667	868	1027	868
query69	1247	279	295	279
query70	1372	1111	1107	1107
query71	724	320	326	320
query72	9153	2255	2215	2215
query73	3315	688	359	359
query74	9046	9241	8819	8819
query75	7717	3133	2707	2707
query76	8888	1227	795	795
query77	1151	421	335	335
query78	9582	11940	9433	9433
query79	15137	578	590	578
query80	2211	547	512	512
query81	566	259	229	229
query82	486	153	122	122
query83	422	281	285	281
query84	309	96	86	86
query85	1273	370	333	333
query86	368	326	321	321
query87	4181	4140	4083	4083
query88	5664	2240	2267	2240
query89	507	357	322	322
query90	2531	232	231	231
query91	173	143	112	112
query92	87	69	68	68
query93	6391	978	659	659
query94	1161	390	284	284
query95	405	335	321	321
query96	518	594	284	284
query97	2698	2739	2623	2623
query98	254	230	230	230
query99	1437	1435	1275	1275
Total cold run time: 300578 ms
Total hot run time: 170136 ms

@felixwluo
Copy link
Contributor Author

felixwluo commented Aug 6, 2025

Official documentation will be updated later.

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

ClickBench: Total hot run time: 33.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit df75760fddf06ab74c1933ef08a6a60c91938b72, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.25	0.07	0.06
query4	1.61	0.10	0.10
query5	0.43	0.41	0.43
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.57	0.49	0.46
query10	0.52	0.52	0.54
query11	0.16	0.11	0.10
query12	0.15	0.11	0.10
query13	0.67	0.64	0.65
query14	0.96	1.06	1.05
query15	0.97	0.87	0.88
query16	0.39	0.39	0.40
query17	1.08	1.06	1.09
query18	0.21	0.20	0.20
query19	2.03	1.84	1.87
query20	0.01	0.02	0.01
query21	15.37	0.84	0.55
query22	0.78	1.13	0.67
query23	14.98	1.17	0.64
query24	6.96	1.15	0.91
query25	0.48	0.16	0.09
query26	0.55	0.16	0.14
query27	0.06	0.06	0.05
query28	9.42	0.84	0.45
query29	12.57	3.87	3.34
query30	3.10	3.00	2.94
query31	2.82	0.57	0.40
query32	3.24	0.58	0.50
query33	3.02	3.19	3.29
query34	16.09	5.37	4.97
query35	4.88	5.05	4.97
query36	0.68	0.52	0.52
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.9 s
Total hot run time: 33.29 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/23) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixwluo felixwluo mentioned this pull request Aug 7, 2025
Merged
9 tasks
@dataroaring dataroaring merged commit 58640ca into apache:master Aug 8, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
@felixwluo
[feat](cloud) change the type to optional in the alter storage vault …
23bbb52 
…command (#54394)

### What problem does this PR solve?

change the type to optional in the alter storage vault command
before
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "type"="S3",
  "s3.access_key" = "new_ak"
);
```
now
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "s3.access_key" = "new_ak"
);
```
@github-actions github-actions bot mentioned this pull request Aug 8, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
@felixwluo
[feat](cloud) change the type to optional in the alter storage vault …
567f398 
…command (#54394)

### What problem does this PR solve?

change the type to optional in the alter storage vault command
before
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "type"="S3",
  "s3.access_key" = "new_ak"
);
```
now
```
ALTER STORAGE VAULT vault_name
PROPERTIES (
  "s3.access_key" = "new_ak"
);
```
@github-actions github-actions bot mentioned this pull request Aug 8, 2025
Merged
morrySnow pushed a commit that referenced this pull request Aug 8, 2025
@github-actions @felixwluo
branch-3.1: [feat](cloud) change the type to optional in the alter st…
98b279e 
…orage vault command #54394 (#54476)

Cherry-picked from #54394

Co-authored-by: lw112 <131352377+felixwluo@users.noreply.github.com>
dataroaring pushed a commit that referenced this pull request Aug 12, 2025
@github-actions @felixwluo
branch-3.0: [feat](cloud) change the type to optional in the alter st…
9f5cd1a 
…orage vault command #54394 (#54475)

Cherry-picked from #54394

Co-authored-by: lw112 <131352377+felixwluo@users.noreply.github.com>
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Open
dataroaring pushed a commit to apache/doris-website that referenced this pull request Sep 11, 2025
@felixwluo
[doc](cloud) change the type to optional in the alter storage vault c…
ab28c55 
…ommand (#2713)

Relation: apache/doris#54394
## Versions 

- [x] dev
- [x] 3.1
- [x] 3.0
- [ ] 2.1
- [ ] 2.0

## Languages

- [x] Chinese
- [x] English

## Docs Checklist

- [ ] Checked by AI
- [ ] Test Cases Built
CalvinKirs pushed a commit to CalvinKirs/doris-website that referenced this pull request Sep 11, 2025
@felixwluo @CalvinKirs
[doc](cloud) change the type to optional in the alter storage vault c…
f612f82 
…ommand (apache#2713)

Relation: apache/doris#54394
## Versions 

- [x] dev
- [x] 3.1
- [x] 3.0
- [ ] 2.1
- [ ] 2.0

## Languages

- [x] Chinese
- [x] English

## Docs Checklist

- [ ] Checked by AI
- [ ] Test Cases Built
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.8-merged dev/3.1.0-merged p0_easy reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@felixwluo @hello-stephen @doris-robot @starocean999 @dataroaring @morrySnow